Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug pc commands ros feedback #126

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Debug pc commands ros feedback #126

wants to merge 19 commits into from

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Jan 25, 2023

Use this branch to diagnose/fix the pc_commands_ros_feeback.launch.py failing test.

issue: #117

also see discussion: #125 (comment)

@andermi
proof of concept for looping over simulation parameters
f3270ac 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
try to fix
7bd9088 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
set on_exit shutdown in launch files
d78e16e 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
install script and example batch sim params; add launch file; set def…
93866dc 
…ault to use example sim params

Signed-off-by: Michael Anderson <[email protected]>
@andermi
add rosbag and a log file; rename some things
c2cf6ca 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/batch_sim
326197f
@andermi
fix max scale in example yaml
a2203b6 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
typo
e393454 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
remove noisy prints; get tests passing
94fce17 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
use argparse
48667fd 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
mbari_wec/model.sdf is now generated by empy
7001355 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
try to debug pc commands test
0ce6b71 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
debug pc commands test
e0c211b 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
increase timeout; remove debugging prints
b1c274c 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
keep debugging
78ed18a 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
keep debugging
b800a3a 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
keep debugging
469aca9 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
remove debugging code
c45d4ea 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Copy link
Collaborator Author

andermi commented Jan 25, 2023 •
edited
Loading

I tried to set the base to #125 but for some reason github doesn't see the diff...

Edit: TIL -- two-dot vs three-dot diffs

@andermi andermi mentioned this pull request Jan 25, 2023
Merged
@andermi
rebase to show diff with #125
34f2855 
Signed-off-by: Michael Anderson <[email protected]>
@andermi andermi changed the base branch from main to andermi/batch_sim January 25, 2023 19:31
@quarkytale quarkytale linked an issue Jan 27, 2023 that may be closed by this pull request
launch_pc_commands_ros_feedback.launch.py Timeout #117
Closed
@mabelzhang
Copy link
Collaborator

Suggestion from meeting: Retest until fail or retest until pass on the gtest. Could save 35m. Typically we do retest until fail, so that it runs just that test.

Base automatically changed from andermi/batch_sim to main January 31, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

@quarkytale quarkytale Awaiting requested review from quarkytale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

launch_pc_commands_ros_feedback.launch.py Timeout
2 participants
@andermi @mabelzhang