Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

launch_pc_commands_ros_feedback.launch.py Timeout #117

Closed
Tracked by #81
andermi opened this issue Jan 21, 2023 · 6 comments · Fixed by #120 · May be fixed by #126
Closed
Tracked by #81

launch_pc_commands_ros_feedback.launch.py Timeout #117

andermi opened this issue Jan 21, 2023 · 6 comments · Fixed by #120 · May be fixed by #126

Comments

@andermi
Copy link
Collaborator

andermi commented Jan 21, 2023

For some reason this test still intermittently times out:
35 - launch_pc_commands_ros_feedback.launch.py (Failed)

Opening a ticket to keep track of this.
@mabelzhang
Copy link
Collaborator

Linking to the PR where the flakiness was discovered: #111

@mabelzhang mabelzhang mentioned this issue Jan 23, 2023
Closed
@mabelzhang mabelzhang mentioned this issue Jan 23, 2023
Closed
12 tasks
@andermi andermi linked a pull request Jan 23, 2023 that will close this issue
Fix flaky PC commands test #120
Merged
@mabelzhang
Copy link
Collaborator

(Maybe) Fixed in #120
Reopen if comes back

@andermi andermi reopened this Jan 24, 2023
@andermi
Copy link
Collaborator Author

andermi commented Jan 24, 2023

Still a problem in #125

@andermi andermi mentioned this issue Jan 24, 2023
Merged
@andermi
Copy link
Collaborator Author

andermi commented Jan 25, 2023

#125 (comment)

@andermi andermi mentioned this issue Jan 25, 2023
Draft
@quarkytale quarkytale linked a pull request Jan 27, 2023 that will close this issue
Debug pc commands ros feedback #126
Draft
@mabelzhang
Copy link
Collaborator

Latest: Currently temporarily bandaged on main by testing until pass. But that means CI will run for a long time. Flakiness is temporarily solved. Test failure should still be fixed.

@andermi
Copy link
Collaborator Author

andermi commented Aug 9, 2023

Haven't seen the issue in a while

@andermi andermi closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky PC commands test osrf/mbari_wec_gz
Debug pc commands ros feedback osrf/mbari_wec_gz
2 participants
@mabelzhang @andermi