Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stratos pubkey support #3896

Closed

Conversation

Xiong-stratos
Copy link

What is the purpose of the change:

Add stratos pubkey support

Linear Task

Brief Changelog

Testing and Verifying

Copy link

vercel bot commented Oct 16, 2024

@Xiong-stratos is attempting to deploy a commit to the OsmoLabs Team on Vercel.

A member of the Team first needs to authorize it.

@@ -566,6 +566,10 @@ export class CosmosAccountImpl {
return "/injective.crypto.v1beta1.ethsecp256k1.PubKey";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR. Is this code addressing a specific issue within the app? I believe we no longer use this store for signing transactions. If so, could you please point it out so we can ensure proper QA? Also, we already include Stratos in our getPublicKeyTypeUrl which is used in all of our signing methods.

Copy link

@BoThe1K BoThe1K Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoseRFelix we have this issue during integration osmosis-labs/assetlists#1946 (comment) . We have resolved this in keplr wallet, but on ui looks like it use own logic and broadcast without keplr (so keplr looks like only to sign).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this is working locally?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoseRFelix tested, still same problem, looks like codechanges not fixing an issue and problem in som another place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants