Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verified for STOS #1946

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

BoThe1K
Copy link
Contributor

@BoThe1K BoThe1K commented Oct 15, 2024

Description

Checklist

Upgrading Asset to Verified

If upgrading an Asset to Verified, please see the requirements specified at LISTING, and ensure the following:

  • Asset is defined thoroughly at the Cosmos Chain Registry.
    • A meaningful description (and extended_description, unless: meme, variant, or non-primary chain token).
    • Associated socials, including website and twitter (unless: meme, variant, or non-primary chain token).
    • Logo Image has a square Aspect Ratio, < 250 KB file size, and appropriate visual contrast with Osmosis Zone colors.
  • Liquidity: This pool contains contains at least $1k USD-worth of liquidity of the asset (Provide Pool ID): ______ (Skip if alloy constituent)

'Verified' Status Validation Checklist (to be completed by Osmosis Zone maintainers):

  • Verify appearance and metadata
  • Accurate Price
  • Trading and routing functionality
  • Withdraw and Deposit
    • Deposit Transaction URL (if in-app)

@BoThe1K
Copy link
Contributor Author

BoThe1K commented Oct 15, 2024

@BoThe1K
Copy link
Contributor Author

BoThe1K commented Oct 15, 2024

Hi! I have a question. We could not find a token in the "Trade" section, however we could find it into a pool. When I go to https://app.osmosis.zone/pool/2216 and click on "Trade Pair" I see a following errors (in screenshots).

denom is not a valid chain denom (ibc/ABD49F44559C…57CC458459CB6A67CEBD66E23C7674A0B2B445230BDA1F6C)

Should we register it somewhere else or is it something that asset not verified?

Screenshot 2024-10-15 at 17 27 13 Screenshot 2024-10-15 at 17 27 38

@JeremyParish69
Copy link
Contributor

Hi! I have a question. We could not find a token in the "Trade" section, however we could find it into a pool. When I go to https://app.osmosis.zone/pool/2216 and click on "Trade Pair" I see a following errors (in screenshots).

denom is not a valid chain denom (ibc/ABD49F44559C…57CC458459CB6A67CEBD66E23C7674A0B2B445230BDA1F6C)

Should we register it somewhere else or is it something that asset not verified?

The error arises because it is a preview asset (which are not routed), although we are working on changing the behaviour so that even preview assets are tradable.

@JeremyParish69
Copy link
Contributor

JeremyParish69 commented Oct 15, 2024

I do not see an extended_description, nor socials for the asset at the Chain Registry.

@BoThe1K
Copy link
Contributor Author

BoThe1K commented Oct 15, 2024

@JeremyParish69 PR for socials, description + extended_description cosmos/chain-registry#5459

@JeremyParish69
Copy link
Contributor

Hmm, Deposits seem to fail
image
pubkey doesn't match signer address...

@BoThe1K
Copy link
Contributor Author

BoThe1K commented Oct 16, 2024

@JeremyParish69 which wallet are you using? We have integration with keplr for signing (pub key type):
https://github.com/chainapsis/keplr-wallet/pull/1105/files

@alexstratos
Copy link

alexstratos commented Oct 16, 2024

@JeremyParish69 I just did a quick test, if I make the ibc transfer through https://app.osmosis.zone/portfolio?transferDirection=deposit&transferAsset=STOS, it fails with similar pubkey error. but if I directly make a ibc transfer on keplr wallet, it works fine. the signing msg the keplr wallet receives is also mostly identical.
`
// from osmosis app
{
"account_number": "4062",
"chain_id": "stratos-1",
"fee": {
"gas": "135297",
"amount": [
{
"amount": "216475200000000",
"denom": "wei"
}
]
},
"memo": "FE",
"msgs": [
{
"type": "cosmos-sdk/MsgTransfer",
"value": {
"receiver": "osmo1whnzllzrsqkkn658czztpd8n6j4grl47ymgkqq",
"sender": "st1tfqhz86fuhfuh9psdqsetl86evr90rqy6f739x",
"source_channel": "channel-1",
"source_port": "transfer",
"timeout_height": {
"revision_height": "22465310",
"revision_number": "1"
},
"token": {
"amount": "1545792644216376092",
"denom": "wei"
}
}
}
],
"sequence": "2",
"timeout_height": "5571823"
}

// from keplr directly
{
"account_number": "4062",
"chain_id": "stratos-1",
"fee": {
"gas": "140248",
"amount": [
{
"amount": "168297600000000",
"denom": "wei"
}
]
},
"memo": "",
"msgs": [
{
"type": "cosmos-sdk/MsgTransfer",
"value": {
"receiver": "osmo1whnzllzrsqkkn658czztpd8n6j4grl47ymgkqq",
"sender": "st1tfqhz86fuhfuh9psdqsetl86evr90rqy6f739x",
"source_channel": "channel-1",
"source_port": "transfer",
"timeout_height": {
"revision_height": "22465418",
"revision_number": "1"
},
"token": {
"amount": "600000000000000000",
"denom": "wei"
}
}
}
],
"sequence": "2"
}
`

@BoThe1K
Copy link
Contributor Author

BoThe1K commented Oct 16, 2024

@JeremyParish69 PR here to resolve pub key issue:
osmosis-labs/osmosis-frontend#3896

@JeremyParish69
Copy link
Contributor

@JeremyParish69 PR here to resolve pub key issue: osmosis-labs/osmosis-frontend#3896

Thanks for this. I think that will help provide context for getting the issue resolved.

@BoThe1K
Copy link
Contributor Author

BoThe1K commented Oct 18, 2024

Should work right now @JeremyParish69

@JeremyParish69 JeremyParish69 merged commit 33f04ba into osmosis-labs:main Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants