Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for backward compatibility, reintroduce julia_to_gap #1056

Merged
merged 2 commits into from
Oct 21, 2024

Commits on Oct 1, 2024

  1. for backward compatibility, reintroduce juliao_gap

    - provide generic methods that delegate to `GapObj_internal`
    - add tests
    - move an `end` of a `@testset` to a better place
    ThomasBreuer committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4ec53ab View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. next iteration

    - change the `julia_to_gap` methods such that `GapObj_internal`
      gets called with the same `recursive` value;
      this way, we get the same behaviour for `julia_to_gap` as before
      the switch to `GapObj_internal`,
    - extend the tests of the backwards compatibility to the conversions
      promised in the documentation,
    - fix the conversion rule for matrices:
      call the conversion of the row objects with the given `recursive` value
      in order to convert the matrix entries or not, as requested,
    - and use the term `FFE` in the documentation, not `GapFFE`
    ThomasBreuer committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4ffb34c View commit details
    Browse the repository at this point in the history