for backward compatibility, reintroduce julia_to_gap
#1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- provide generic methods that delegate to `GapObj_internal` - add tests - move an `end` of a `@testset` to a better place
lgoettgens
reviewed
Oct 1, 2024
src/julia_to_gap.jl
Outdated
Comment on lines
355
to
356
| julia_to_gap(obj::Any) = GapObj_internal(obj, nothing, Val(false)) | ||
| julia_to_gap(obj::Any; recursive::Bool) = julia_to_gap(obj) |
There was a problem hiding this comment.
Julia doesn't use kwargs for dispatch. The dispatcher can therefore not distinguish these two.
Solution: unify into one method with a default kwarg value
Suggested change
| julia_to_gap(obj::Any) = GapObj_internal(obj, nothing, Val(false)) | |
| julia_to_gap(obj::Any; recursive::Bool) = julia_to_gap(obj) | |
| julia_to_gap(obj::Any; recursive::Bool=false) = GapObj_internal(obj, nothing, Val(false)) |
There was a problem hiding this comment.
Why do we not honor recursive ?
There was a problem hiding this comment.
Right.
We do not just want to have the generic methods but also the "old" behaviour for vectors, matrices, etc.
I will update the pull request.
- change the `julia_to_gap` methods such that `GapObj_internal` gets called with the same `recursive` value; this way, we get the same behaviour for `julia_to_gap` as before the switch to `GapObj_internal`, - extend the tests of the backwards compatibility to the conversions promised in the documentation, - fix the conversion rule for matrices: call the conversion of the row objects with the given `recursive` value in order to convert the matrix entries or not, as requested, - and use the term `FFE` in the documentation, not `GapFFE`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
- Coverage 74.98% 74.92% -0.06%
==========================================
Files 55 55
Lines 4549 4551 +2
==========================================
- Hits 3411 3410 -1
- Misses 1138 1141 +3
|
fingolfin
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
genericjulia_to_gapmethods that delegate toGapObj_internal, in order to get the same behaviour forjulia_to_gapas before the switch toGapObj_internalrecursivevalue in order to either convert the matrix entries or not, as requested,julia_to_gapfor the conversions promised in the documentation,endof a@testsetto a better place,FFEin the documentation, notGapFFE