Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPP0RT-1586: remove some date manipulation #250

Closed
wants to merge 2 commits into from
Closed

SUPP0RT-1586: remove some date manipulation #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ff9fd0
SUPP0RT-1586: remove some date manipulation
sinejespersen Jul 30, 2024
d4ae479
SUPP0RT-1586: changelog
sinejespersen Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.

## [Unreleased]


- [#243](https://github.com/os2display/display-admin-client/pull/250)
- Fix null bug: replace valueAsDate with target.value as valueAsDate was null

- [#242](https://github.com/os2display/display-admin-client/pull/243)
- Add entry in example config for midttrafik api key
- Clean up multi select component a bit, replace reduce with Map logic
Expand Down
7 changes: 2 additions & 5 deletions src/components/util/schedule/schedule.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,9 @@ function Schedule({ schedules, onChange }) {
* @param {object} target - Input target.
*/
const setDateValue = (scheduleId, target) => {
const date = target.valueAsDate;
const scheduleDate = new Date(
date.getTime() + 60 * 1000 * date.getTimezoneOffset()
);
const date = new Date(target.value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change

const date = target.valueAsDate;

https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement#valueasdate

Copy link
Contributor

@tuj tuj Jul 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, update changelog and create a better description of the PR :)


changeSchedule(scheduleId, target.id, scheduleDate);
changeSchedule(scheduleId, target.id, date);
};

/**
Expand Down
Loading