SUPP0RT-1586: remove some date manipulation #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuj
requested changes
Jul 30, 2024
| const scheduleDate = new Date( | ||
| date.getTime() + 60 * 1000 * date.getTimezoneOffset() | ||
| ); | ||
| const date = new Date(target.value); |
There was a problem hiding this comment.
Why change
const date = target.valueAsDate;
https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement#valueasdate
There was a problem hiding this comment.
Also, update changelog and create a better description of the PR :)
tuj
previously approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://jira.itkdev.dk/browse/SUPP0RT-1586
Description
The input was broken, so I figure maybe the repeating rules were not saved correctly.
I am not sure what goes before this, but it seems this pr introduced the error.