Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-42711] Improve TCK error messages #9908

Merged
merged 1 commit into from
Oct 19, 2024

Commits on Oct 17, 2024

  1. Improve TCK error messages

    * So it shows the TypeDescriptor's of the parameters.
    * Example 1:
        java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
        '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
        '[true, false]' from 'ruby' provider, value: [true, false] (Meta Object: Array)
        failed:
        Expected PolyglotException, but executed successfully.
        Result: null
        Exception: null
        Snippet: lambda x, y: x < y
        Parameter 0 Snippet: -> { [1, 2] }
        Parameter 0 Declared Return Type: [object & Array<number> & Iterable<number>]
        Parameter 0 Returned Value Type: [object & Iterable<number> & Array<number>]
        Parameter 1 Snippet: -> { [true, false] }
        Parameter 1 Declared Return Type: [object & Array<<any>> & Iterable<<any>>]
        Parameter 1 Returned Value Type: [object & Array<boolean> & Iterable<boolean>]
      vs before:
        java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
        '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
        '[true, false]' from 'ruby' provider, value: [true, false] (Meta Object: Array)
        failed:
        Expected PolyglotException, but executed successfully.
        Result: null
        Exception: null
        Snippet: lambda x, y: x < y
        Parameter 0 Snippet: -> { [1, 2] }
        Parameter 1 Snippet: -> { [true, false] }
    * Example 2:
        java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
        '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
        '[]' from 'ruby' provider, value: [] (Meta Object: Array)
        failed:
        Expected PolyglotException, but executed successfully.
        Result: null
        Exception: null
        Snippet: lambda x, y: x < y
        Parameter 0 Snippet: -> { [1, 2] }
        Parameter 0 Declared Return Type: [object & Array<number> & Iterable<number>]
        Parameter 0 Returned Value Type: [object & Array<number> & Iterable<number>]
        Parameter 1 Snippet: -> { [] }
        Parameter 1 Declared Return Type: [object & Array<<any>> & Iterable<<any>>]
        Parameter 1 Returned Value Type: [object & Iterable<<all>> & Array<<all>>]
      vs before:
        java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
        '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
        '[]' from 'ruby' provider, value: [] (Meta Object: Array)
        failed:
        Expected PolyglotException, but executed successfully.
        Result: null
        Exception: null
        Snippet: lambda x, y: x < y
        Parameter 0 Snippet: -> { [1, 2] }
        Parameter 1 Snippet: -> { [] }
    eregon committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    734d5bb View commit details
    Browse the repository at this point in the history