Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-42711] Improve TCK error messages #9908

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Oct 17, 2024

* So it shows the TypeDescriptor's of the parameters.
* Example 1:
    java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
    '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
    '[true, false]' from 'ruby' provider, value: [true, false] (Meta Object: Array)
    failed:
    Expected PolyglotException, but executed successfully.
    Result: null
    Exception: null
    Snippet: lambda x, y: x < y
    Parameter 0 Snippet: -> { [1, 2] }
    Parameter 0 Declared Return Type: [object & Array<number> & Iterable<number>]
    Parameter 0 Returned Value Type: [object & Iterable<number> & Array<number>]
    Parameter 1 Snippet: -> { [true, false] }
    Parameter 1 Declared Return Type: [object & Array<<any>> & Iterable<<any>>]
    Parameter 1 Returned Value Type: [object & Array<boolean> & Iterable<boolean>]
  vs before:
    java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
    '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
    '[true, false]' from 'ruby' provider, value: [true, false] (Meta Object: Array)
    failed:
    Expected PolyglotException, but executed successfully.
    Result: null
    Exception: null
    Snippet: lambda x, y: x < y
    Parameter 0 Snippet: -> { [1, 2] }
    Parameter 1 Snippet: -> { [true, false] }
* Example 2:
    java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
    '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
    '[]' from 'ruby' provider, value: [] (Meta Object: Array)
    failed:
    Expected PolyglotException, but executed successfully.
    Result: null
    Exception: null
    Snippet: lambda x, y: x < y
    Parameter 0 Snippet: -> { [1, 2] }
    Parameter 0 Declared Return Type: [object & Array<number> & Iterable<number>]
    Parameter 0 Returned Value Type: [object & Array<number> & Iterable<number>]
    Parameter 1 Snippet: -> { [] }
    Parameter 1 Declared Return Type: [object & Array<<any>> & Iterable<<any>>]
    Parameter 1 Returned Value Type: [object & Iterable<<all>> & Array<<all>>]
  vs before:
    java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
    '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
    '[]' from 'ruby' provider, value: [] (Meta Object: Array)
    failed:
    Expected PolyglotException, but executed successfully.
    Result: null
    Exception: null
    Snippet: lambda x, y: x < y
    Parameter 0 Snippet: -> { [1, 2] }
    Parameter 1 Snippet: -> { [] }

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 17, 2024
* So it shows the TypeDescriptor's of the parameters.
* Example 1:
    java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
    '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
    '[true, false]' from 'ruby' provider, value: [true, false] (Meta Object: Array)
    failed:
    Expected PolyglotException, but executed successfully.
    Result: null
    Exception: null
    Snippet: lambda x, y: x < y
    Parameter 0 Snippet: -> { [1, 2] }
    Parameter 0 Declared Return Type: [object & Array<number> & Iterable<number>]
    Parameter 0 Returned Value Type: [object & Iterable<number> & Array<number>]
    Parameter 1 Snippet: -> { [true, false] }
    Parameter 1 Declared Return Type: [object & Array<<any>> & Iterable<<any>>]
    Parameter 1 Returned Value Type: [object & Array<boolean> & Iterable<boolean>]
  vs before:
    java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
    '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
    '[true, false]' from 'ruby' provider, value: [true, false] (Meta Object: Array)
    failed:
    Expected PolyglotException, but executed successfully.
    Result: null
    Exception: null
    Snippet: lambda x, y: x < y
    Parameter 0 Snippet: -> { [1, 2] }
    Parameter 1 Snippet: -> { [true, false] }
* Example 2:
    java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
    '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
    '[]' from 'ruby' provider, value: [] (Meta Object: Array)
    failed:
    Expected PolyglotException, but executed successfully.
    Result: null
    Exception: null
    Snippet: lambda x, y: x < y
    Parameter 0 Snippet: -> { [1, 2] }
    Parameter 0 Declared Return Type: [object & Array<number> & Iterable<number>]
    Parameter 0 Returned Value Type: [object & Array<number> & Iterable<number>]
    Parameter 1 Snippet: -> { [] }
    Parameter 1 Declared Return Type: [object & Array<<any>> & Iterable<<any>>]
    Parameter 1 Returned Value Type: [object & Iterable<<all>> & Array<<all>>]
  vs before:
    java.lang.AssertionError: Running snippet '<' retrieved from 'python' provider (java class com.oracle.graal.python.tck.PythonProvider) with parameters:
    '[1, 2]' from 'ruby' provider, value: [1, 2] (Meta Object: Array)
    '[]' from 'ruby' provider, value: [] (Meta Object: Array)
    failed:
    Expected PolyglotException, but executed successfully.
    Result: null
    Exception: null
    Snippet: lambda x, y: x < y
    Parameter 0 Snippet: -> { [1, 2] }
    Parameter 1 Snippet: -> { [] }
@graalvmbot graalvmbot closed this Oct 19, 2024
@graalvmbot graalvmbot deleted the bd/improve-tck-error-messages branch October 19, 2024 06:34
@graalvmbot graalvmbot merged commit 7c9f85b into master Oct 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants