-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include object id/key in invalid object errors #301
Merged
Mat001
merged 9 commits into
optimizely:master
from
stoneman:stoneman/include-identifiers-in-errors
Oct 10, 2023
Merged
feat: include object id/key in invalid object errors #301
Mat001
merged 9 commits into
optimizely:master
from
stoneman:stoneman/include-identifiers-in-errors
Oct 10, 2023
Commits on May 19, 2022
-
feat: include object id/key in invalid object errors
- Include object `id`/`key` in errors when objects not found in datafile - Modifies invalid object `id`/`key` log messages to make them consistent Include object `id`/`key` in errors when an object is not found makes them available to the user or the custom error handler. One example of why this is useful is that the `key` of an experiment could be used within a custom error handler to fetch the details of the experiment. This would indicate whether the experiment has been paused (in which case the error could be ignored) or archived (in which case the code referencing the experiment should be removed from the application).
Configuration menu - View commit details
-
Copy full SHA for 06209f7 - Browse repository at this point
Copy the full SHA 06209f7View commit details
Commits on May 20, 2022
-
feat: expose object identifiers as error properties
- Expose the object identifiers as error properties so that they are easier to use in error handlers. - Encapsulate the error messages within the error objects to enforce consistency and to simplify initialization - Use the messages of the error objects as log messages to enforce consistency and to simplify logging
Configuration menu - View commit details
-
Copy full SHA for 2a5e013 - Browse repository at this point
Copy the full SHA 2a5e013View commit details
Commits on Sep 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 718a56b - Browse repository at this point
Copy the full SHA 718a56bView commit details
Commits on Sep 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a111991 - Browse repository at this point
Copy the full SHA a111991View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8e918f - Browse repository at this point
Copy the full SHA d8e918fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe39020 - Browse repository at this point
Copy the full SHA fe39020View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ea73df - Browse repository at this point
Copy the full SHA 5ea73dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3311d7a - Browse repository at this point
Copy the full SHA 3311d7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 732326b - Browse repository at this point
Copy the full SHA 732326bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.