feat: include object id/key in invalid object errors #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoneman
force-pushed
the
stoneman/include-identifiers-in-errors
branch
from
c035384
to
b8093b1
Compare
- Include object `id`/`key` in errors when objects not found in datafile - Modifies invalid object `id`/`key` log messages to make them consistent Include object `id`/`key` in errors when an object is not found makes them available to the user or the custom error handler. One example of why this is useful is that the `key` of an experiment could be used within a custom error handler to fetch the details of the experiment. This would indicate whether the experiment has been paused (in which case the error could be ignored) or archived (in which case the code referencing the experiment should be removed from the application).
stoneman
force-pushed
the
stoneman/include-identifiers-in-errors
branch
from
b8093b1
to
06209f7
Compare
- Expose the object identifiers as error properties so that they are easier to use in error handlers. - Encapsulate the error messages within the error objects to enforce consistency and to simplify initialization - Use the messages of the error objects as log messages to enforce consistency and to simplify logging
|
We're super late on looking at this @stoneman. Sorry about that. Is this change still relevant? |
Mat001
reviewed
Sep 27, 2023
Mat001
reviewed
Sep 28, 2023
Mat001
reviewed
Sep 28, 2023
Mat001
reviewed
Sep 28, 2023
Mat001
reviewed
Sep 28, 2023
Mat001
reviewed
Sep 28, 2023
Mat001
reviewed
Sep 28, 2023
Mat001
approved these changes
Sep 29, 2023
Closed
|
@stoneman I have your PR working and ready to be merged. Would you mind signing this license form please so we can merge? |
|
@Mat001 signed! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
id/keyin errors when objects not found in datafileid/keylog messages to make them consistentInclude object
id/keyin errors when an object is not found makes them available to the user or the custom error handler.One example of why this is useful is that the
keyof an experiment could be used within a custom error handler to fetch the details of the experiment. This would indicate whether the experiment has been paused (in which case the error could be ignored) or archived (in which case the code referencing the experiment should be removed from the application).This change will impact existing custom error handlers which are expecting an error class rather than an error object instance.
Test plan
Jira ticket:
https://jira.sso.episerver.net/browse/FSSDK-9439