Fix part of #5343: Exempt targets incompatible with code coverage

domain/src/test/java/org/oppia/android/domain/oppialogger/analytics/BUILD.bazel

@@ -323,3 +323,31 @@ oppia_android_test(
         "//utility/src/main/java/org/oppia/android/util/networking:debug_module",
     ],
 )
+
+oppia_android_test(
+    name = "FirestoreDataControllerTest",
+    srcs = ["FirestoreDataControllerTest.kt"],
+    custom_package = "org.oppia.android.domain.oppialogger.analytics",
+    test_class = "org.oppia.android.domain.oppialogger.analytics.FirestoreDataControllerTest",
+    test_manifest = "//domain:test_manifest",
+    deps = [
+        "//:dagger",
+        "//domain/src/main/java/org/oppia/android/domain/oppialogger/analytics:cpu_module",
+        "//domain/src/main/java/org/oppia/android/domain/oppialogger/analytics:data_controller",
+        "//domain/src/main/java/org/oppia/android/domain/oppialogger/analytics:prod_module",
+        "//testing",
+        "//testing/src/main/java/org/oppia/android/testing/data:data_provider_test_monitor",
+        "//testing/src/main/java/org/oppia/android/testing/logging:event_log_subject",
+        "//testing/src/main/java/org/oppia/android/testing/robolectric:test_module",
+        "//testing/src/main/java/org/oppia/android/testing/threading:test_coroutine_dispatchers",
+        "//testing/src/main/java/org/oppia/android/testing/threading:test_module",
+        "//testing/src/main/java/org/oppia/android/testing/time:test_module",
+        "//third_party:androidx_test_ext_junit",
+        "//third_party:com_google_truth_truth",
+        "//third_party:junit_junit",
+        "//third_party:org_robolectric_robolectric",
+        "//third_party:robolectric_android-all",
+        "//utility/src/main/java/org/oppia/android/util/locale:prod_module",
+        "//utility/src/main/java/org/oppia/android/util/networking:debug_module",
+    ],
+)

scripts/src/java/org/oppia/android/scripts/coverage/RunCoverage.kt

@@ -85,12 +85,12 @@ class RunCoverage(
   private val reportFormat: ReportFormat,
   private val reportOutputPath: String,
   private val commandExecutor: CommandExecutor,
-  private val scriptBgDispatcher: ScriptBackgroundCoroutineDispatcher
+  private val scriptBgDispatcher: ScriptBackgroundCoroutineDispatcher,
+  private val testFileExemptionTextProtoPath: String = "scripts/assets/test_file_exemptions.pb"
 ) {
   private val bazelClient by lazy { BazelClient(File(repoRoot), commandExecutor) }
 
   private val rootDirectory = File(repoRoot).absoluteFile
-  private val testFileExemptionTextProto = "scripts/assets/test_file_exemptions"
 
   /**
    * Executes coverage analysis for the specified file.
@@ -104,17 +104,24 @@ class RunCoverage(
    *     the file is exempted from having a test file, an empty list is returned
    */
   fun execute() {
-    val testFileExemptionList = loadTestFileExemptionsProto(testFileExemptionTextProto)
-      .testFileExemptionList
-      .filter { it.testFileNotRequired }
-      .map { it.exemptedFilePath }
-
-    if (filePath in testFileExemptionList) {
-      println("This file is exempted from having a test file; skipping coverage check.")
+    val testFileExemptions = loadTestFileExemptionsProto(testFileExemptionTextProtoPath)
+    val filesNotNeedingTests =
+      testFileExemptions
+        .testFileExemptionList.filter { it.testFileNotRequired }.map { it.exemptedFilePath }
+    val filesIncompatibleWithCodeCoverage =
+      testFileExemptions
+        .testFileExemptionList
+        .filter { it.sourceFileIsIncompatibleWithCodeCoverage }
+        .map { it.exemptedFilePath }
+
+    if (filePath in filesNotNeedingTests || filePath in filesIncompatibleWithCodeCoverage) {
+      if (filePath in filesIncompatibleWithCodeCoverage) {
+        println("This file is incompatible with code coverage tooling; skipping coverage check.")
+      } else println("This file is exempted from having a test file; skipping coverage check.")
     } else {
       val testFilePaths = findTestFiles(repoRoot, filePath)
       check(testFilePaths.isNotEmpty()) {
-        "No appropriate test file found for $filePath"
+        "No appropriate test file found for $filePath."
       }
 
       val testTargets = bazelClient.retrieveBazelTargets(testFilePaths)
@@ -218,8 +225,8 @@ private fun getReportOutputPath(
   return "$repoRoot/coverage_reports/$fileWithoutExtension/$defaultFilename"
 }
 
-private fun loadTestFileExemptionsProto(testFileExemptiontextProto: String): TestFileExemptions {
-  return File("$testFileExemptiontextProto.pb").inputStream().use { stream ->
+private fun loadTestFileExemptionsProto(testFileExemptionProtoPath: String): TestFileExemptions {
+  return File(testFileExemptionProtoPath).inputStream().use { stream ->
     TestFileExemptions.newBuilder().also { builder ->
       builder.mergeFrom(stream)
     }.build()

scripts/src/java/org/oppia/android/scripts/proto/script_exemptions.proto

@@ -49,6 +49,13 @@ message TestFileExemptions {
 
       // Overrides the minimum coverage percent required for the given file.
       int32 override_min_coverage_percent_required = 3;
+
+      // TODO(#5481): Remove this property & all corresponding exemptions once all test
+      // configurations are compatible with code coverage tooling.
+      // A medium-term state to indicate that something about this source file's build config, or
+      // that of its test(s), are not compatible with the current code coverage tooling and thus
+      // should be ignored.
+      bool source_file_is_incompatible_with_code_coverage = 4;
     }
   }
 }

scripts/src/javatests/org/oppia/android/scripts/coverage/BUILD.bazel

@@ -8,7 +8,7 @@ kt_jvm_test(
     name = "RunCoverageTest",
     size = "large",
     srcs = ["RunCoverageTest.kt"],
-    shard_count = 4,
+    shard_count = 8,
     deps = [
         "//scripts:test_file_check_assets",
         "//scripts/src/java/org/oppia/android/scripts/coverage:run_coverage_lib",

scripts/src/javatests/org/oppia/android/scripts/coverage/RunCoverageTest.kt

@@ -8,6 +8,7 @@ import org.junit.Test
 import org.junit.rules.TemporaryFolder
 import org.oppia.android.scripts.common.CommandExecutorImpl
 import org.oppia.android.scripts.common.ScriptBackgroundCoroutineDispatcher
+import org.oppia.android.scripts.proto.TestFileExemptions
 import org.oppia.android.scripts.testing.TestBazelWorkspace
 import org.oppia.android.testing.assertThrows
 import java.io.ByteArrayOutputStream
@@ -197,20 +198,53 @@ class RunCoverageTest {
   @Test
   fun testRunCoverage_testFileExempted_noCoverage() {
     System.setOut(PrintStream(outContent))
-    val exemptedFilePath = "app/src/main/java/org/oppia/android/app/activity/ActivityComponent.kt"
+    val exemptedFilePath = "SourceExemptedFromHavingTestFile.kt"
+    val testFileExemption = TestFileExemptions.TestFileExemption.newBuilder().apply {
+      this.exemptedFilePath = exemptedFilePath
+      this.testFileNotRequired = true
+    }.build()
+    val testFileExemptions = TestFileExemptions.newBuilder().apply {
+      addTestFileExemption(testFileExemption)
+    }.build()
 
     RunCoverage(
       "${tempFolder.root}",
       exemptedFilePath,
       ReportFormat.MARKDOWN,
       markdownOutputPath,
       longCommandExecutor,
-      scriptBgDispatcher
+      scriptBgDispatcher,
+      testFileExemptionTextProtoPath = createTestFileExemptionsProtoFile(testFileExemptions)
     ).execute()
 
-    assertThat(outContent.toString().trim()).isEqualTo(
-      "This file is exempted from having a test file; skipping coverage check."
-    )
+    assertThat(outContent.toString().trim())
+      .isEqualTo("This file is exempted from having a test file; skipping coverage check.")
+  }
+
+  @Test
+  fun testRunCoverage_sourceFileIncompatibleWithCodeCoverage_exemptedFromCoverageAnalysis() {
+    System.setOut(PrintStream(outContent))
+    val incompatibleFilePath = "SourceIncompatibleWithCoverage.kt"
+    val testFileExemption = TestFileExemptions.TestFileExemption.newBuilder().apply {
+      this.exemptedFilePath = incompatibleFilePath
+      this.sourceFileIsIncompatibleWithCodeCoverage = true
+    }.build()
+    val testFileExemptions = TestFileExemptions.newBuilder().apply {
+      addTestFileExemption(testFileExemption)
+    }.build()
+
+    RunCoverage(
+      "${tempFolder.root}",
+      incompatibleFilePath,
+      ReportFormat.MARKDOWN,
+      markdownOutputPath,
+      longCommandExecutor,
+      scriptBgDispatcher,
+      testFileExemptionTextProtoPath = createTestFileExemptionsProtoFile(testFileExemptions)
+    ).execute()
+
+    assertThat(outContent.toString().trim())
+      .isEqualTo("This file is incompatible with code coverage tooling; skipping coverage check.")
   }
 
   @Test
@@ -1127,6 +1161,12 @@ class RunCoverageTest {
     return htmlText
   }
 
+  private fun createTestFileExemptionsProtoFile(testFileExemptions: TestFileExemptions): String {
+    return tempFolder.newFile("test_file_exemptions.pb").also {
+      it.outputStream().use(testFileExemptions::writeTo)
+    }.path
+  }
+
   private fun initializeCommandExecutorWithLongProcessWaitTime(): CommandExecutorImpl {
     return CommandExecutorImpl(
       scriptBgDispatcher, processTimeout = 5, processTimeoutUnit = TimeUnit.MINUTES

testing/src/test/java/org/oppia/android/testing/robolectric/BUILD.bazel

@@ -4,6 +4,42 @@ Tests for Robolectric-specific utilities and configurations.
 
 load("//:oppia_android_test.bzl", "oppia_android_test")
 
+oppia_android_test(
+    name = "OppiaShadowActivityManagerTest",
+    srcs = ["OppiaShadowActivityManagerTest.kt"],
+    custom_package = "org.oppia.android.testing.robolectric",
+    test_class = "org.oppia.android.testing.robolectric.OppiaShadowActivityManagerTest",
+    test_manifest = "//testing:test_manifest",
+    deps = [
+        "//:dagger",
+        "//testing/src/main/java/org/oppia/android/testing/robolectric:oppia_shadow_activity_manager",
+        "//third_party:androidx_core_core",
+        "//third_party:androidx_test_ext_junit",
+        "//third_party:com_google_truth_truth",
+        "//third_party:junit_junit",
+        "//third_party:org_robolectric_robolectric",
+        "//third_party:robolectric_android-all",
+    ],
+)
+
+oppia_android_test(
+    name = "OppiaShadowTrafficStatsTest",
+    srcs = ["OppiaShadowTrafficStatsTest.kt"],
+    custom_package = "org.oppia.android.testing.robolectric",
+    test_class = "org.oppia.android.testing.robolectric.OppiaShadowTrafficStatsTest",
+    test_manifest = "//testing:test_manifest",
+    deps = [
+        "//:dagger",
+        "//testing/src/main/java/org/oppia/android/testing/robolectric:oppia_shadow_traffic_stats",
+        "//third_party:androidx_core_core",
+        "//third_party:androidx_test_ext_junit",
+        "//third_party:com_google_truth_truth",
+        "//third_party:junit_junit",
+        "//third_party:org_robolectric_robolectric",
+        "//third_party:robolectric_android-all",
+    ],
+)
+
 oppia_android_test(
     name = "ShadowBidiFormatterTest",
     srcs = ["ShadowBidiFormatterTest.kt"],

utility/src/test/java/org/oppia/android/util/logging/BUILD.bazel

@@ -22,6 +22,23 @@ kt_android_library(
     ],
 )
 
+oppia_android_test(
+    name = "CurrentAppScreenNameIntentDecoratorTest",
+    srcs = ["CurrentAppScreenNameIntentDecoratorTest.kt"],
+    custom_package = "org.oppia.android.util.logging",
+    test_class = "org.oppia.android.util.logging.CurrentAppScreenNameIntentDecoratorTest",
+    test_manifest = "//utility:test_manifest",
+    deps = [
+        "//:dagger",
+        "//third_party:androidx_test_ext_junit",
+        "//third_party:androidx_test_ext_truth",
+        "//third_party:com_google_truth_truth",
+        "//third_party:org_robolectric_robolectric",
+        "//third_party:robolectric_android-all",
+        "//utility/src/main/java/org/oppia/android/util/logging:current_app_screen_name_intent_decorator",
+    ],
+)
+
 oppia_android_test(
     name = "EventBundleCreatorTest",
     srcs = ["EventBundleCreatorTest.kt"],

utility/src/test/java/org/oppia/android/util/profile/BUILD.bazel

@@ -4,6 +4,43 @@ Tests for profile utilities.
 
 load("//:oppia_android_test.bzl", "oppia_android_test")
 
+oppia_android_test(
+    name = "CurrentUserProfileIdIntentDecoratorTest",
+    srcs = ["CurrentUserProfileIdIntentDecoratorTest.kt"],
+    custom_package = "org.oppia.android.util.profile",
+    test_class = "org.oppia.android.util.profile.CurrentUserProfileIdIntentDecoratorTest",
+    test_manifest = "//utility:test_manifest",
+    deps = [
+        "//third_party:androidx_test_ext_junit",
+        "//third_party:com_google_truth_extensions_truth-liteproto-extension",
+        "//third_party:com_google_truth_truth",
+        "//third_party:junit_junit",
+        "//third_party:org_robolectric_robolectric",
+        "//third_party:robolectric_android-all",
+        "//utility/src/main/java/org/oppia/android/util/profile:current_user_profile_id_intent_decorator",
+    ],
+)
+
+oppia_android_test(
+    name = "DirectoryManagementUtilTest",
+    srcs = ["DirectoryManagementUtilTest.kt"],
+    custom_package = "org.oppia.android.util.profile",
+    test_class = "org.oppia.android.util.profile.DirectoryManagementUtilTest",
+    test_manifest = "//utility:test_manifest",
+    deps = [
+        "//:dagger",
+        "//testing/src/main/java/org/oppia/android/testing/robolectric:test_module",
+        "//testing/src/main/java/org/oppia/android/testing/time:test_module",
+        "//third_party:androidx_test_ext_junit",
+        "//third_party:com_google_truth_truth",
+        "//third_party:junit_junit",
+        "//third_party:org_robolectric_robolectric",
+        "//third_party:robolectric_android-all",
+        "//utility/src/main/java/org/oppia/android/util/logging:prod_module",
+        "//utility/src/main/java/org/oppia/android/util/profile:directory_management_util",
+    ],
+)
+
 oppia_android_test(
     name = "ProfileNameValidatorTest",
     srcs = ["ProfileNameValidatorTest.kt"],

utility/src/test/java/org/oppia/android/util/profile/DirectoryManagementUtilTest.kt

@@ -128,7 +128,7 @@ class DirectoryManagementUtilTest {
 
     assertThat(success).isTrue()
     assertThat(dir.exists()).isTrue()
-    assertThat(dir.listFiles().isEmpty()).isTrue()
+    assertThat(dir.listFiles()?.isEmpty()).isTrue()
   }
 
   private fun getAbsoluteDirPath(path: String): String {