Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #5343: Exempt targets incompatible with code coverage #5480

Merged
merged 4 commits into from
Aug 10, 2024
Merged

Fix part of #5343: Exempt targets incompatible with code coverage #5480

merged 4 commits into from
Aug 10, 2024

Commits on Aug 8, 2024

  1. Exempt targets incompatible with code coverage. 

    PR description will contain much more context, but this also includes
adding missing test declarations and some other fixes in existing code.
    @BenHenning
    BenHenning committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    46a0b04 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Address self-review comments. 

    This removes code that was moved to a downstream PR, adds missing test
coverage for the new exemption behavior, and improves the messaging for
the new exemption behavior.

Also, updates the shard count for RunCoverageTest since 4 seemed to be a
bit too few when running the test locally since the tests can take quite
some time to complete.
    @BenHenning
    BenHenning committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e4d0aa8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into exempt-test-targets-incompatible-with-cod… 

    …e-coverage
    @BenHenning
    BenHenning committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    172b91f View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Address review comment.

    @BenHenning
    BenHenning committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    3f8ea11 View commit details
    Browse the repository at this point in the history