Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1433 Logging Exceptions to Both Console and Exception Loggers #5396

Merged
merged 4 commits into from
May 20, 2024
Merged

Fix #1433 Logging Exceptions to Both Console and Exception Loggers #5396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3936364
Resolve the test build error
XichengSpencer Jul 4, 2023
098b665
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
XichengSpencer May 7, 2024
885b9c9
Add logException to exceptionLogger in AnalyticsController.kt
XichengSpencer May 7, 2024
4be6832
Merge branch 'develop' into #1433
adhiamboperes May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion domain/src/main/java/org/oppia/android/domain/oppialogger/analytics/AnalyticsController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ class AnalyticsController @Inject constructor(
.addEventLogsToUpload(eventLog)
.build()
} else {
// TODO(#1433): Refactoring for logging exceptions to both console and exception loggers.
val exception =
IllegalStateException("Least Recent Event index absent -- EventLogCacheStoreSize is 0")
consoleLogger.e("AnalyticsController", "Failure while caching event.", exception)
Expand Down
1 change: 0 additions & 1 deletion .../main/java/org/oppia/android/domain/oppialogger/analytics/PerformanceMetricsController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ class PerformanceMetricsController @Inject constructor(
.addOppiaMetricLog(oppiaMetricLog)
.build()
} else {
// TODO(#1433): Refactoring for logging exceptions to both console and exception loggers.
val exception =
IllegalStateException(
"Least Recent Event index absent -- MetricLogStorageCacheSize is 0"
Expand Down
2 changes: 1 addition & 1 deletion domain/src/main/java/org/oppia/android/domain/oppialogger/exceptions/ExceptionsController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,12 @@ class ExceptionsController @Inject constructor(
.addExceptionLog(exceptionLog)
.build()
} else {
// TODO(#1433): Refactoring for logging exceptions to both console and exception loggers.
val exception =
NullPointerException(
"Least Recent Exception index absent -- ExceptionLogCacheStoreSize is 0"
)
consoleLogger.e(EXCEPTIONS_CONTROLLER, exception.toString())
exceptionLogger.logException(exception)
}
}
return@storeDataAsync oppiaExceptionLogs.toBuilder().addExceptionLog(exceptionLog).build()
Expand Down
Loading