Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1433 Logging Exceptions to Both Console and Exception Loggers #5396

Merged
merged 4 commits into from
May 20, 2024

Conversation

XichengSpencer
Copy link
Collaborator

@XichengSpencer XichengSpencer commented May 14, 2024

Explanation Fix #1433

There are 3 TODO marks the place where we want to have both have log in both Console and Exception Loggers
By checking 3 related TODOs, only TODO in ExceptionController needs to add the exception logger for logging and I added it as the issue required and removed the TODO comment.
The other 2 TODOs already meet the requirement of the issue, so I simply deleted TODO comments.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@XichengSpencer XichengSpencer requested a review from a team as a code owner May 14, 2024 14:24
@XichengSpencer XichengSpencer self-assigned this May 14, 2024
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XichengSpencer! The code changes look good, but the PR description is a bit vagues and does not describe the changes made in the PR. Please update and reassign for merging.

@oppiabot oppiabot bot added the PR: LGTM label May 17, 2024
Copy link

oppiabot bot commented May 17, 2024

Hi @XichengSpencer, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes enabled auto-merge (squash) May 20, 2024 03:21
@adhiamboperes adhiamboperes merged commit 6f5f8fa into oppia:develop May 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure the Logger
2 participants