Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't Merge] Test Robolectric Update on CI #5125

Closed
wants to merge 71 commits into from

Commits on Nov 11, 2022

  1. Bump Robolectric to 4.7

    This is the first version with support for building on M1 Macs
    adhiamboperes committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    bed24bb View commit details
    Browse the repository at this point in the history
  2. Fix jetifying issue with bcprov-jdk15on-1.68.jar

    Ignore bcprov-jdk15on during jetifying 3p libraries
    Note this will not be necessary in AGP 7.1+ as per [Resolution](https://issuetracker.google.com/issues/159151549#comment12)
    adhiamboperes committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    00c3814 View commit details
    Browse the repository at this point in the history
  3. Update espresso-core to 3.5.0-alpha03

    According to robolectric/robolectric#6593 (comment), Robolectric instrumenting androidx.* packages by default., but Espresso relies on this logic.
    adhiamboperes committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    2c6f739 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Configuration menu
    Copy the full SHA
    e39b29f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    79645b2 View commit details
    Browse the repository at this point in the history
  3. Update robolectric version for bazel

    Bump to 4.7
    adhiamboperes committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    ec39ab5 View commit details
    Browse the repository at this point in the history
  4. Update espresso version for bazel

    Bump to 3.5.0, latest stable version
    adhiamboperes committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4d4d7b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Configuration menu
    Copy the full SHA
    f81bdb1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c51017f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1eadc30 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Refactor tests

    Some of the production code was updated in the previous commit.
    adhiamboperes committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    b258164 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50ac657 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6ad3a23 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    913e2fe View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7ea7a13 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2558c0b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4b2f8da View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bb42456 View commit details
    Browse the repository at this point in the history
  9. Fix nits

    adhiamboperes committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    277f3c9 View commit details
    Browse the repository at this point in the history
  10. Remove large tests that can't run on either local or CI.

    These scenarios are covered in other tests so I'm fine with not trying to make them work.
    adhiamboperes committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    8e7f3f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Bazel BUILD dependency

    adhiamboperes committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    bd844aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a264b3a View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Update boolean naming

    adhiamboperes committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    f68e8ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9237c66 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Log optional survey response

    This commit sets up the logging infrastructure, including tests.
    
    Since Firestore is introduced, some tests in the app module may be broken, and will be fixed in the next commit.
    
    This commit soes not handle actual upload to firestore yet, because firebase auth is not yet properly configured.
    adhiamboperes committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    cb22dfb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    110d96f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c1d4c19 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    931019a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    32566a6 View commit details
    Browse the repository at this point in the history
  6. Fix import ordering

    adhiamboperes committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    ba318eb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f573158 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6b4d488 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. Configuration menu
    Copy the full SHA
    44e37b0 View commit details
    Browse the repository at this point in the history
  2. Fix npe in domain/src/test/java/org/oppia/android/domain/oppialogger/…

    …loguploader/LogUploadWorkerTest.kt
    adhiamboperes committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    d1a11d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    cb25e31 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Introduce AuthenticationController

    This new controller provides functionality to retrieve the current signed in user and also sign in user anonymously, and can be called from anywhere. This decouples authentication from a firestore-only use case.
    
    The implementation relies on an AuthenticationListener to switch out the real and fake authentication controllers for testing purposes.
    
    This commit has not included the Auth module in app module test files(Fragment/Acticity tests), hence these will fail to build with a dagger error. This is fixed in the subsequent commit.
    adhiamboperes committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b03011c View commit details
    Browse the repository at this point in the history
  2. Fix missing KDOc

    adhiamboperes committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d9a7fe5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c0a48da View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e6c2568 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9ad162a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0de4f3a View commit details
    Browse the repository at this point in the history
  7. Add more tests for FirestoreDataController

    Now that we can successfully mock firebase auth, we can test for upload, cache and sync scenarios.
    adhiamboperes committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b7bafb5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7b13358 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fe1dfdf View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9d66b9f View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Add TestAuthenticationModule to test files.

    This is to allow the fake version of firebase
    adhiamboperes committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    6f1fb2a View commit details
    Browse the repository at this point in the history
  2. Fix failing tests

    adhiamboperes committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e3f1e84 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Rename variable in ViewEventLogsViewModel.kt

    To be more descriptive of its purpose.
    adhiamboperes committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2996787 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec2e3f8 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Fix proguarding

    Lower the versions of Firestore and Auth.
    
    The previously included versions were not compatible with older libraries currently in use within the project.
    
    I also added a dontwarn to proguard for FirestoreChannel
    adhiamboperes committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    52c438a View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Fix failing eventlog test

    Switch out logger for controller which should swap debug vs real event loggers
    adhiamboperes committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    dc5dac3 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Fix failing tests

    adhiamboperes committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    93d3c6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a04caa9 View commit details
    Browse the repository at this point in the history
  3. Exempt AuthenticationModule from tests

    I have been unable to mock firebase for this test class since it is supposed to verify the real controller is returned, and not a mock.
    adhiamboperes committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    3e81132 View commit details
    Browse the repository at this point in the history
  4. Ignore failing test

    This test cannot pass due to the version of robolectric.
    
    There is a conflict between Firestore's SQLite database connection and Robolectric's shadow implementation of SQLite. Firestore is trying to access an illegal connection pointer (pointer 52), which indicates a problem with the database connection.
    adhiamboperes committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    aeb213e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    781644f View commit details
    Browse the repository at this point in the history
  6. Reformat @ignore

    adhiamboperes committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    ca5cd8c View commit details
    Browse the repository at this point in the history
  7. Refactor test

    Allow real auth in tests for firestore
    adhiamboperes committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    6a0b78f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Merge remote-tracking branch 'upstream/develop' into bump-robolectric…

    …-version
    
    # Conflicts:
    #	third_party/versions.bzl
    #	utility/build.gradle
    adhiamboperes committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    626473c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a817b82 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d864d59 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    7469a51 View commit details
    Browse the repository at this point in the history
  2. Blacklist bcprov

    adhiamboperes committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    4c863c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4926657 View commit details
    Browse the repository at this point in the history
  4. Blacklist bcprov

    adhiamboperes committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    52e784e View commit details
    Browse the repository at this point in the history
  5. Update espresso

    adhiamboperes committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    0210137 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Update robolectric to 4.8.2

    This version contains fixes related to sqlite connections in M1 Macs, and idlin resource timeouts.
    adhiamboperes committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e92be89 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'bump-robolectric-version' into test-robolectric-update

    # Conflicts:
    #	app/build.gradle
    #	data/build.gradle
    #	domain/build.gradle
    #	testing/build.gradle
    adhiamboperes committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e18cd55 View commit details
    Browse the repository at this point in the history
  3. Fix dependencies

    adhiamboperes committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    8317370 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. bump down to 4.7

    adhiamboperes committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6f36718 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. update workspace

    adhiamboperes committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d397f62 View commit details
    Browse the repository at this point in the history