[Don't Merge] Test Robolectric Update on CI #5125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first version with support for building on M1 Macs
Ignore bcprov-jdk15on during jetifying 3p libraries Note this will not be necessary in AGP 7.1+ as per [Resolution](https://issuetracker.google.com/issues/159151549#comment12)
According to robolectric/robolectric#6593 (comment), Robolectric instrumenting androidx.* packages by default., but Espresso relies on this logic.
Bump to 4.7
Bump to 3.5.0, latest stable version
Some of the production code was updated in the previous commit.
These scenarios are covered in other tests so I'm fine with not trying to make them work.
This commit sets up the logging infrastructure, including tests. Since Firestore is introduced, some tests in the app module may be broken, and will be fixed in the next commit. This commit soes not handle actual upload to firestore yet, because firebase auth is not yet properly configured.
This test cannot pass due to the version of robolectric. There is a conflict between Firestore's SQLite database connection and Robolectric's shadow implementation of SQLite. Firestore is trying to access an illegal connection pointer (pointer 52), which indicates a problem with the database connection.
…ional-response-upload
Allow real auth in tests for firestore
…-version # Conflicts: # third_party/versions.bzl # utility/build.gradle
adhiamboperes
requested review from
BenHenning
and removed request for
BenHenning
adhiamboperes
requested review from
BenHenning
and removed request for
BenHenning
This version contains fixes related to sqlite connections in M1 Macs, and idlin resource timeouts.
# Conflicts: # app/build.gradle # data/build.gradle # domain/build.gradle # testing/build.gradle
|
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
oppiabot
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Bumped robolectric version to 4.7 due to sqlite incompatibility with Firestore.
This PR is only intended to test whether the previously failing tests pass on CI.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: