Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel): add more trace attributes #40

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat(otel): add more trace attributes #40

merged 1 commit into from
Oct 11, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Oct 11, 2023

example:

image

Signed-off-by: Boris Glimcher [email protected]

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #40 (4dcff7a) into main (4f9f0f9) will decrease coverage by 0.28%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main     #40      +/-   ##
========================================
- Coverage   8.42%   8.15%   -0.28%     
========================================
  Files          4       4              
  Lines        178     184       +6     
========================================
  Hits          15      15              
- Misses       163     169       +6     
Files Coverage Δ
spdk/jsonrpc.go 14.70% <0.00%> (-0.92%) ⬇️

@glimchb glimchb marked this pull request as ready for review October 11, 2023 16:03
@glimchb glimchb requested a review from a team as a code owner October 11, 2023 16:03
@glimchb glimchb merged commit 68dd762 into main Oct 11, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant