feat(otel): add more trace attributes

Signed-off-by: Boris Glimcher <[email protected]>
opiproject · Oct 11, 2023 · 68dd762 · 68dd762
1 parent 19e2c3c
commit 68dd762
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/spdk/jsonrpc.go b/spdk/jsonrpc.go
@@ -105,9 +105,16 @@ func (r *Client) Call(ctx context.Context, method string, args, result interface
  id := atomic.AddUint64(&r.id, 1)
 
  _, childSpan := r.tracer.Start(ctx, "spdk."+method)
- childSpan.SetAttributes(attribute.Int64("request.id", int64(id)))
  defer childSpan.End()
 
+ if childSpan.IsRecording() {
+ childSpan.SetAttributes(
+ attribute.Int64("request.id", int64(id)),
+ attribute.String("spdk.socket", r.socket),
+ attribute.String("spdk.transport", r.transport),
+ )
+ }
+
  request := RPCRequest{
  RPCVersion: JSONRPCVersion,
  ID: id,