Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screen width not being respected in task view #943

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Mar 12, 2024

Rationale

Fix #936

Pre-requisite: #942

Changes

  • wrap content of <pre> tags used in task view
  • wrap flags values

@benoit74 benoit74 self-assigned this Mar 12, 2024
@benoit74 benoit74 marked this pull request as ready for review March 12, 2024 10:13
@benoit74 benoit74 requested a review from rgaudin March 12, 2024 10:13
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (7c68b32) to head (0af274a).

❗ Current head 0af274a differs from pull request most recent head aa61f88. Consider uploading reports for the commit aa61f88 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   87.84%   87.82%   -0.02%     
==========================================
  Files          93       93              
  Lines        5307     5299       -8     
==========================================
- Hits         4662     4654       -8     
  Misses        645      645              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74
Copy link
Collaborator Author

While #941 and #939 have both proposed a solution to fix mentioned issue, both are not working according to my tests + forcing a screen width we do not want to set

@benoit74
Copy link
Collaborator Author

@rgaudin ping

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had reviewed this

@benoit74 benoit74 merged commit fd56855 into main Mar 19, 2024
5 checks passed
@benoit74 benoit74 deleted the fix_screen_width branch March 19, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config not displayed properly in not logged-in
2 participants