-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #936 adjust css for std to show config value #939
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
=======================================
Coverage 87.82% 87.82%
=======================================
Files 93 93
Lines 5299 5299
=======================================
Hits 4654 4654
Misses 645 645 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does the 120rem
comes from, is it in line with other components of the page, are you sure it works in all screen widths? Is the result responsive (responsiveness of Zimfarm UI is already limited but we should try to not make it worse)
Do you have some screenshot / video to share the result?
Isn't there also an issue with the command
which might be too long?
@benoit74 Thank you for your valuable feedback. After reviewing the situation, I still believe that setting a maximum width is the best solution to address this issue. We're aware that the stdout can be quite lengthy, which is why overflow: scroll; was initially implemented. However, this approach didn't achieve the desired effect due to the response-table's tendency to expand rows as much as possible, preventing stdout from ever overflowing. I acknowledge that setting the max-width to 120rem may not be the ideal solution, as it could force users to scroll horizontally on smaller screens to view the entire table. The primary goal of introducing a max-width was to prevent stdout from being the cause of table width expansion, given its potential length. Considering the limitations, I propose adjusting the max-width to 40rem. This adjustment would allow users to see up to the first 40 characters at a glance, with the option to scroll horizontally for more information. This method ensures that even on smaller screens, the overall table width remains manageable. I am, of course, open to exploring other solutions and would appreciate any suggestions you might have. Please let me know your thoughts or if there are any alternative approaches you believe we should consider. screenshot.mov |
This is not working + we do not want to force screen width, it is already controlled elsewhere Superseeded by #943 |
Issue: #936
Rationale
The row
Scraper stdout
can sometimes be too long, pushing the value ofConfig
to the far right side of the table, which makes user think they are invisible. So I add max width constrain to the stdout row.Changes
Add max width constrain to the stdout row