-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check recipe flags at schedule creation (including fix for youzim.it) #868
Conversation
…_creation" This reapply commit 7ce4f31
1239c8a
to
3783f1b
Compare
3783f1b
to
4977638
Compare
Nota: do not merge until decision has been taken on openzim/zimit-frontend#42 + synchronization with Travis is needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ; please take a look at suggestions and question
dispatcher/backend/src/tests/integration/routes/schedules/test_zimit.py
Outdated
Show resolved
Hide resolved
Following your review, I made following changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ; couple minor suggestions. I'll let you decide what to do. Please merge yourself
dispatcher/backend/src/tests/integration/routes/schedules/test_zimit.py
Outdated
Show resolved
Hide resolved
Suggested changes made, makes a lot of sense. I converted this PR to Draft so that it is not merged by accident, we need to synchronize with Travis + prepare new env variable for youzim.it |
Rationale
Fix #864 (again)
Fix #867 (mandatory to deploy #864 on youzim.it)
Changes
ZIMIT_DISABLE_ZIM_FILENAME_CHECK
ZIMIT_USE_RELAXED_SCHEMA
which must be set to disable the ZIM filename check