Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validity of zimit flags are not checked at recipe creation #40

Closed
kelson42 opened this issue Nov 4, 2023 · 7 comments
Closed

Validity of zimit flags are not checked at recipe creation #40

kelson42 opened this issue Nov 4, 2023 · 7 comments
Labels
enhancement New feature or request prio1

Comments

@kelson42
Copy link
Contributor

kelson42 commented Nov 4, 2023

I can put a Description which is (for example) longer than 80 characters. This makes the scrape process to die.

UI inputs setting up ZIM metadata should be checked, ideally at user input time, to secure they match our requirements.

@kelson42 kelson42 added the enhancement New feature or request label Nov 4, 2023
@kelson42 kelson42 pinned this issue Nov 4, 2023
@kelson42 kelson42 added the prio1 label Nov 4, 2023
@benoit74
Copy link
Collaborator

benoit74 commented Nov 6, 2023

This is most probably a regression on Zimfarm, the farm should not accept a task with such a description. I'm checking this.
Checking field length at user input time has not been implemented so far, the UI has no information about expected maximum length, API is not providing this information.
I would suggest to split this second part of the issue, since this would probably be implemented in a second effort (while first part is very important AFAIK)

@benoit74
Copy link
Collaborator

benoit74 commented Nov 6, 2023

Second part is already tracked here indeed: openzim/zimfarm#835

@benoit74
Copy link
Collaborator

benoit74 commented Nov 6, 2023

Second part tracked here now: #41

@benoit74 benoit74 changed the title ZIM metadata inputs are not checked in the UI Validity of zimit flags are not checked at recipe creation Nov 6, 2023
@benoit74
Copy link
Collaborator

benoit74 commented Nov 6, 2023

First part of this issue has been fixed and deployed upstream

But it looks like it is not really nicely handled in zimit UI, I'm looking into it:
image

@benoit74
Copy link
Collaborator

benoit74 commented Nov 6, 2023

This is indeed intentional in zimit-frontend code ; I will close this issue (we cannot set description too long anymore) and open another one to discuss 500 error specifically.

@benoit74 benoit74 closed this as completed Nov 6, 2023
@benoit74
Copy link
Collaborator

benoit74 commented Nov 6, 2023

Upstream deployment reverted due to #43

@benoit74 benoit74 reopened this Nov 6, 2023
@benoit74
Copy link
Collaborator

Fixed again by deployment of openzim/zimfarm#868

@kelson42 kelson42 unpinned this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio1
Projects
None yet
Development

No branches or pull requests

2 participants