Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: support temporary mount options #78

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ilovezfs
Copy link
Contributor

Some issues here:

  • no option string parsing in the kernel though that's supported on Linux, FreeBSD, and illumos
  • noxattr would need special handling to turn off xattr in zfsvfs
  • async, sync, and strictatime would need changes in zfs_register_callbacks
  • zfs_parse_mount_options is being called twice for legacy mounts and failing because they use do_mount
  • positives are not overriding negatives (e.g., if non-temporary value is nobrowse and you pass -o browse, nothing happens) so I guess we'll need to infer positives from the absence of the relevant flag
  • side effect such as turning on strictatime, which seems to be intended on Linux at least
  • probably more

#define MNTOPT_SETUID "setuid" /* Set uid allowed */
#define MNTOPT_NOSETUID "nosetuid" /* Set uid not allowed */
#define MNTOPT_SETUID "suid" /* Set uid allowed */
#define MNTOPT_NOSETUID "nosuid" /* Set uid not allowed */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this undo the #ifdef apple (you will translate later), then we can drop the #ifdef?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants