Skip to content

Commit

Permalink
macOS: race in registerDevice and offline
Browse files Browse the repository at this point in the history
Which can cause "is busy" on the zvol.

Most easily tested with zfs-tester run over;

cli_root/zfs_create, zvol/zvol_cli, zvol/zvol_misc

which results in testpool/vol.33979-renamed "is busy".

This should be replaced with the proper "wait" condition, whatever
that may be.
  • Loading branch information
lundman committed Jul 29, 2021
1 parent 776e1bf commit a50c37b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions module/os/macos/zfs/zvolIO.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1102,6 +1102,7 @@ zvolRenameDevice(zvol_state_t *zv)
* like zpool export.
*/
/* Inform clients of this device that name has changed */
delay(hz<<1);
if (zvol->offlineDevice() != 0 ||
zvol->onlineDevice() != 0) {
dprintf("%s media reset failed\n", __func__);
Expand Down

0 comments on commit a50c37b

Please sign in to comment.