-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPENVINO CODE] Added Fill-in-the-middle(FIM) support #848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must include a licence file to the HF model repository based on this.
The FIM feature description should be added to the README.md
modules/openvino_code/package.json
Outdated
"openvinoCode.startToken": { | ||
"order": 7, | ||
"type": "string", | ||
"default": "<fim_prefix>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepseek-coder
has a different FIM tokens format: "<|fim▁begin|>"
, check tokenizer.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to make a FIM feature a check box and to hardcode FIM tokens, as long as the model list is predefined.
@@ -4,22 +4,27 @@ enum ModelId { | |||
CODE_T5_220M = 'Salesforce/codet5p-220m-py', | |||
DECICODER_1B_OPENVINO_INT8 = 'chgk13/decicoder-1b-openvino-int8', | |||
STABLECODE_COMPLETION_ALPHA_3B_4K_OPENVINO_INT8 = 'chgk13/stablecode-completion-alpha-3b-4k-openvino-int8', | |||
//deepseek_coder = 'deepseek-ai/deepseek-coder-6.7b-instruct', | |||
deepseek_coder_7b = 'kumarijy/deepseek-coder-1.3b-instruct_ov', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use ALL_CAPS for consistency. It is also a 1_3B model, not a 7B.
a06eed8
to
1048ec4
Compare
Adding FIM support through deepseek-coder-1.3b-instruct and changed model names at Frontend