Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSCode Extension] Adding stablecode-3b-int8 model #753

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

kumarijy
Copy link
Contributor

@kumarijy kumarijy commented Nov 1, 2023

made changes to the relevant files in order to add stablecode-3m model to OV code completion extension @apaniukov

@kumarijy kumarijy requested a review from a team as a code owner November 1, 2023 07:32
@@ -171,7 +171,8 @@
"default": "codet5p-220m-py",
"enum": [
"codet5p-220m-py",
"decicoder-1b-openvino-int8"
"decicoder-1b-openvino-int8",
"stablecode-completion-3b"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add int8 to the model name: "stablecode-completion-3b-int8"

};

export const MODEL_SUPPORTED_FEATURES: Record<ModelName, Features[]> = {
[ModelName.CODE_T5_220M]: [Features.CODE_COMPLETION],
[ModelName.DECICODER_1B_OPENVINO_INT8]: [Features.CODE_COMPLETION, Features.SUMMARIZATION],
[ModelName.STABLECODE_COMPLETION_ALPHA_3B_4K_OPENVINO_INT8]: [Features.CODE_COMPLETION],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model might support the summarization feature too, you need to check it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increment extension patch version in package.json file (L4, "version" field) from 0.0.5 to 0.0.6

}

export enum ModelName {
CODE_T5_220M = 'codet5p-220m-py',
DECICODER_1B_OPENVINO_INT8 = 'decicoder-1b-openvino-int8',
STABLECODE_COMPLETION_ALPHA_3B_4K_OPENVINO_INT8 = 'stablecode-completion-3b',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add -int8 here too.

}

export enum ModelName {
CODE_T5_220M = 'codet5p-220m-py',
DECICODER_1B_OPENVINO_INT8 = 'decicoder-1b-openvino-int8',
STABLECODE_COMPLETION_ALPHA_3B_4K_OPENVINO_INT8 = 'stablecode-completion-3b',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New model name should also be added to side panel select options: side-panel-ui/src/components/sections/ServerSection/ModelSelect/ModelSelect.tsx (const options: SelectOptionProps<ModelName>[], L6-L9)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I would suggest to make it more dynamic, e.g.

const options: SelectOptionProps<ModelName>[] = Object.values(ModelName).map((value) => ({ value }));

@yatarkan yatarkan changed the title Adding stablecode-3m model to Open Vino code completion extension [VSCode Extension] Adding stablecode-3m model Nov 2, 2023
@apaniukov
Copy link
Contributor

It seems like the old package-lock.json has been deleted. @kumarijy include the new one in the PR.

@apaniukov apaniukov changed the title [VSCode Extension] Adding stablecode-3m model [VSCode Extension] Adding stablecode-3b-int8 model Nov 9, 2023
@andrei-kochin andrei-kochin enabled auto-merge (squash) November 10, 2023 15:23
@ilya-lavrenov ilya-lavrenov merged commit d471555 into openvinotoolkit:master Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants