Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NVIDIA] Fix Unit Tests #745

Merged
merged 2 commits into from
Oct 10, 2023
Merged

[NVIDIA] Fix Unit Tests #745

merged 2 commits into from
Oct 10, 2023

Conversation

redradist
Copy link
Contributor

@redradist redradist commented Oct 10, 2023 •
edited
Loading

Description

Changes:

  • Previously in release mode some of Unit Tests expected to crash with ASSERT_DEATH, but after switching to OPENVINO_ASSERT which always throws exception it is not anymore a case
  • Updated MatMul test which not always converts to FP16

@redradist redradist requested a review from a team as a code owner October 10, 2023 11:43
@github-actions github-actions bot added the category: NVIDIA plugin OpenVINO NVIDIA plugin label Oct 10, 2023
@redradist redradist mentioned this pull request Oct 10, 2023
Closed
@nkogteva nkogteva enabled auto-merge (squash) October 10, 2023 12:15
@redradist
Copy link
Contributor Author

@nkogteva I suggest to enable Unit Tests for NVIDIA plugin by default, to avoid such thing in future

@nkogteva
Copy link
Contributor

@nkogteva I suggest to enable Unit Tests for NVIDIA plugin by default, to avoid such thing in future

They are already enabled by default in CI.

@nkogteva nkogteva merged commit b21bc7c into openvinotoolkit:master Oct 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkogteva nkogteva nkogteva approved these changes

Assignees
No one assigned
Labels
category: NVIDIA plugin OpenVINO NVIDIA plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redradist @nkogteva @lohika-denis-kotov