Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] update to GSDK 4.4.0 #756

Merged
merged 5 commits into from
Dec 26, 2023

Conversation

lmnotran
Copy link
Contributor

@lmnotran lmnotran commented Dec 19, 2023

This updates the repo to work with the Gecko SDK v4.4.0 release


Other changes

Copy link
Contributor

@romacdon romacdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes are needed.

- gcc_ver: 12.2.Rel1
gcc_download_url: https://developer.arm.com/-/media/Files/downloads/gnu/12.2.rel1/binrel/arm-gnu-toolchain-12.2.rel1-x86_64-arm-none-eabi.tar.xz
gcc_extract_dir: arm-gnu-toolchain-12.2.rel1-x86_64-arm-none-eabi
- gcc_ver: 12.3.Rel1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we include 12.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a newer minor version and I imagine people might want to use it. I don't think we should remove it

script/bootstrap Outdated Show resolved Hide resolved
src/src/radio.c Show resolved Hide resolved
src/src/radio.c Show resolved Hide resolved
src/src/radio.c Show resolved Hide resolved
This adds a new component that generates a config file for SL_OPENTHREAD_STACK_FEATURES_CONFIG_FILE

This is essentially a copy of the ot_stack_ftd/mtd/rcp components except it doesn't define a `OPENTHREAD_<DEVICE_TYPE>` macro
https://github.com/SiliconLabs/gecko_sdk/blob/124fa19de8c8b3961d21c20857f7df32239786da/protocol/openthread/component/ot_stack_ftd.slcc#L21-L26

The component also uses the [validation script](https://github.com/SiliconLabs/gecko_sdk/blob/gsdk_4.4/protocol/openthread/component/script/ot_log_validation.lua) to ensure [`ot_rtt_log`](https://github.com/SiliconLabs/gecko_sdk/blob/gsdk_4.4/protocol/openthread/component/ot_rtt_log.slcc) is in a project if the `OPENTHREAD_CONFIG_LOG_OUTPUT` is set to `OPENTHREAD_CONFIG_LOG_PLATFORM_DEFINED`
This is compiler is a requirement for GSDK 4.4.0
@lmnotran lmnotran force-pushed the feature/update-to-gsdk4.4.0 branch from b70047e to 6e7e388 Compare December 20, 2023 17:17
@lmnotran lmnotran requested a review from romacdon December 20, 2023 17:17
Copy link
Contributor

@romacdon romacdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmnotran lmnotran requested a review from jwhui December 20, 2023 17:45
@lmnotran
Copy link
Contributor Author

Hi @jwhui !

Can you remove the requirement for the arm-gcc-6/7/8/9/10.3 checks and replace them with the new arm-gcc-12.2.Rel1/12.3.Rel1 checks?

Also after this PR is merged, we should be safe to continue approving the dependabot PRs.

Thanks!

Copy link
Contributor

@hemanth-silabs hemanth-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@parag-silabs parag-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@jwhui jwhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏼

@jwhui jwhui merged commit 89c6a08 into openthread:main Dec 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants