-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk] update to GSDK 4.4.0 #756
[sdk] update to GSDK 4.4.0 #756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes are needed.
- gcc_ver: 12.2.Rel1 | ||
gcc_download_url: https://developer.arm.com/-/media/Files/downloads/gnu/12.2.rel1/binrel/arm-gnu-toolchain-12.2.rel1-x86_64-arm-none-eabi.tar.xz | ||
gcc_extract_dir: arm-gnu-toolchain-12.2.rel1-x86_64-arm-none-eabi | ||
- gcc_ver: 12.3.Rel1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we include 12.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a newer minor version and I imagine people might want to use it. I don't think we should remove it
examples/example_vendor_slc_extension/projects/example-vendor-soc-with-buttons.slcp
Show resolved
Hide resolved
This adds a new component that generates a config file for SL_OPENTHREAD_STACK_FEATURES_CONFIG_FILE This is essentially a copy of the ot_stack_ftd/mtd/rcp components except it doesn't define a `OPENTHREAD_<DEVICE_TYPE>` macro https://github.com/SiliconLabs/gecko_sdk/blob/124fa19de8c8b3961d21c20857f7df32239786da/protocol/openthread/component/ot_stack_ftd.slcc#L21-L26 The component also uses the [validation script](https://github.com/SiliconLabs/gecko_sdk/blob/gsdk_4.4/protocol/openthread/component/script/ot_log_validation.lua) to ensure [`ot_rtt_log`](https://github.com/SiliconLabs/gecko_sdk/blob/gsdk_4.4/protocol/openthread/component/ot_rtt_log.slcc) is in a project if the `OPENTHREAD_CONFIG_LOG_OUTPUT` is set to `OPENTHREAD_CONFIG_LOG_PLATFORM_DEFINED`
This is compiler is a requirement for GSDK 4.4.0
b70047e
to
6e7e388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @jwhui ! Can you remove the requirement for the Also after this PR is merged, we should be safe to continue approving the dependabot PRs. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍🏼
This updates the repo to work with the Gecko SDK v4.4.0 release
Other changes
arm-none-eabi-gcc 12
is a requirement of GSDK v4.4.0Build
workflowSL_OPENTHREAD_STACK_FEATURES_CONFIG_FILE
OPENTHREAD_<DEVICE_TYPE>
macrohttps://github.com/SiliconLabs/gecko_sdk/blob/124fa19de8c8b3961d21c20857f7df32239786da/protocol/openthread/component/ot_stack_ftd.slcc#L21-L26
ot_rtt_log
is in a project if theOPENTHREAD_CONFIG_LOG_OUTPUT
is set toOPENTHREAD_CONFIG_LOG_PLATFORM_DEFINED
openthread
submodule to the head ofmain