[radio] fix connectivity issues caused by an accidental deletion in radio.c
#776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deletion caused connectivity problems, preventing networks from being formed properly.
…GET` containing no RCP targets
When running `OT_CMAKE_NINJA_TARGET="ot-cli-ftd" script/build brdXXXXy`, the build script errors with `rcp_targets` being an unbound variable.
```shell
+ rcp_targets=()
+ soc_targets=()
+ for t in '"${OT_CMAKE_NINJA_TARGET[@]}"'
+ [[ ot-cli-ftd =~ .*rcp.* ]]
+ soc_targets+=("$t")
script/build: line 282: rcp_targets[@]: unbound variable
```
This commit fixes the problem by using a default empty string when `rcp_targets` is empty.
lmnotran
requested review from
romacdon,
parag-silabs,
hemanth-silabs,
suveshpratapa and
bertoldi-silabs
bertoldi-silabs
approved these changes
Jan 22, 2024
parag-silabs
approved these changes
Jan 23, 2024
|
@jwhui please review this when you get a chance. Thanks! |
jwhui
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletion should not have happened in
[sdk] update to GSDK 4.4.0#756It caused issues with transmitting secure packets and prevented devices from joining networks.
This PR also includes a diff that was missed in #756 and a minor script fix