Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brazil translation update #931

Open
wants to merge 5 commits into
base: brazil_main
Choose a base branch
from
Open

Brazil translation update #931

wants to merge 5 commits into from

Conversation

junaidwarsivd
Copy link
Contributor

No description provided.

SebaMutuku

This comment was marked as outdated.

Sign in to view

@SebaMutuku
Copy link
Contributor

It would also be nice fixing codacy issues.

@SebaMutuku
Copy link
Contributor

@junaidwarsivd it seems JSON configs are missing translation_text key. You might want to add that to all radio_buttons, check_boxes, spinners like we did for SID team. I'm available to discuss the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebaMutuku SebaMutuku SebaMutuku requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junaidwarsivd @SebaMutuku