Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for OKD installer on master branch #14082

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Add tests for OKD installer on master branch #14082

merged 1 commit into from
Aug 6, 2021

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Dec 4, 2020 •
edited
Loading

This adds always_run: false and optional: true tests for OKD flavor of installer.

Some platforms are not yet fully supported by OKD (azure and baremetal),
so I didn't add tests for those. Rehearsals are failing as it needs openshift/installer#4453

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign sdodson after the PR has been reviewed.
You can assign the PR to them by writing /assign @sdodson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs mentioned this pull request Dec 4, 2020
Merged
@openshift-merge-robot
Copy link
Contributor

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/okd-e2e-vsphere a10a5ebbc9f279a2103e719ae3170fa471454088 link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-vsphere-upi a10a5ebbc9f279a2103e719ae3170fa471454088 link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-aws a10a5ebbc9f279a2103e719ae3170fa471454088 link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-gcp a10a5ebbc9f279a2103e719ae3170fa471454088 link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-gcp-upgrade a10a5ebbc9f279a2103e719ae3170fa471454088 link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-aws-upgrade a10a5ebbc9f279a2103e719ae3170fa471454088 link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-images a10a5ebbc9f279a2103e719ae3170fa471454088 link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-openstack-ipi a10a5ebbc9f279a2103e719ae3170fa471454088 link /test pj-rehearse
ci/prow/pj-rehearse a10a5ebbc9f279a2103e719ae3170fa471454088 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs force-pushed the okd-installer-master branch from a10a5eb to 23aca0a Compare February 16, 2021 09:03
@mtnbikenc
Copy link
Member

/uncc

@openshift-ci-robot openshift-ci-robot removed the request for review from mtnbikenc April 22, 2021 15:35
@vrutkovs vrutkovs force-pushed the okd-installer-master branch 2 times, most recently from 821a651 to 10662a0 Compare April 26, 2021 14:00
@vrutkovs vrutkovs closed this May 29, 2021
@vrutkovs vrutkovs reopened this Jun 15, 2021
@vrutkovs vrutkovs changed the title Add tests for OKD installer on master branch WIP Add tests for OKD installer on master branch Jun 15, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2021
@jhixson74
Copy link
Member

/uncc

@openshift-ci openshift-ci bot removed the request for review from jhixson74 July 8, 2021 01:18
@vrutkovs vrutkovs force-pushed the okd-installer-master branch 3 times, most recently from 961c47d to 5c56ebc Compare July 19, 2021 11:43
@vrutkovs
Copy link
Member Author

/retest

@vrutkovs
Copy link
Member Author 

error: unable to read image registry.build01.ci.openshift.org/ci-op-fsy690q4/stable-initial@sha256:cb655646ec7121e8605d63ee22373186391dc65c5b7851eecb2cdbeda60ae332: unknown: unable to pull manifest from registry.ci.openshift.org/origin/4.9@sha256:cb655646ec7121e8605d63ee22373186391dc65c5b7851eecb2cdbeda60ae332: manifest unknown: manifest unknown
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-07-19T13:08:11Z"}

that's odd, I don't see anything similar or release-controller

/retest

@vrutkovs
Copy link
Member Author

/retest

3 similar comments
@vrutkovs
Copy link
Member Author

/retest

@vrutkovs
Copy link
Member Author

/retest

@vrutkovs
Copy link
Member Author

/retest

@vrutkovs vrutkovs force-pushed the okd-installer-master branch from 5c56ebc to 28ff8b5 Compare July 22, 2021 17:01
@vrutkovs vrutkovs changed the title WIP Add tests for OKD installer on master branch Add tests for OKD installer on master branch Jul 22, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2021
@vrutkovs
Copy link
Member Author

/cc @wking @smarterclayton @patrickdillon @jstuever

@openshift-ci openshift-ci bot requested a review from jstuever July 22, 2021 21:06
@vrutkovs
Copy link
Member Author

/retest

@vrutkovs vrutkovs mentioned this pull request Jul 31, 2021
Merged
@vrutkovs
Copy link
Member Author

vrutkovs commented Aug 3, 2021

/retest

patrickdillon
patrickdillon reviewed Aug 5, 2021
View reviewed changes
ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml Outdated
@@ -2657,6 +2657,505 @@ presubmits:
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )images,?($|\s.*)
- agent: kubernetes
always_run: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be always_run: true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked all e2e tests as always_run: false. okd-images and okd-unit/okd-verifycodegen are flake-free and would run on every PR

@vrutkovs vrutkovs force-pushed the okd-installer-master branch from 28ff8b5 to ba4b28a Compare August 5, 2021 19:54
@vrutkovs
Add tests for OKD installer on master branch
80550ac 
All OKD tests are marked as optional, only AWS install is running on all PRs.

Some platforms are not yet fully supported by OKD (azure and baremetal),
so I didn't add tests for those.
@vrutkovs vrutkovs force-pushed the okd-installer-master branch from ba4b28a to 80550ac Compare August 5, 2021 19:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/okd-e2e-openstack-ipi 23aca0afa9430a5cdcd1ab15f7e206861a457296 link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-vsphere-upi 23aca0afa9430a5cdcd1ab15f7e206861a457296 link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-aws-upgrade 80550ac link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-gcp-upgrade 80550ac link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-vsphere 80550ac link /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-gcp 80550ac link /test pj-rehearse
ci/prow/pj-rehearse 80550ac link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2021
@openshift-ci openshift-ci bot merged commit 902dfc6 into openshift:master Aug 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2021

@vrutkovs: Updated the following 2 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master-postsubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-postsubmits.yaml
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master__okd.yaml using file ci-operator/config/openshift/installer/openshift-installer-master__okd.yaml

In response to this:

This adds always_run: false and optional: true tests for OKD flavor of installer.

Some platforms are not yet fully supported by OKD (azure and baremetal),
so I didn't add tests for those. Rehearsals are failing as it needs openshift/installer#4453

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@jstuever jstuever Awaiting requested review from jstuever

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@wking wking Awaiting requested review from wking

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vrutkovs @openshift-ci-robot @openshift-merge-robot @mtnbikenc @jhixson74 @patrickdillon