Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OKD installer images #4453

Merged
merged 9 commits into from
Jul 18, 2021
Merged

Add OKD installer images #4453

merged 9 commits into from
Jul 18, 2021

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Dec 4, 2020 •
edited
Loading

This adds OKD flavor of installer.

  • Adds a new okd build flag
  • Uses build args to pass "okd" tag in container images (see Add tests for OKD installer on master branch release#14082 for CI integration PR)
  • Pivots FCOS bootstrap to OKD machine-os-content
  • Fetches necessary bootstrap node overlays and OKD-specific manifests on bootstrap from machine-os-content

OKD specific manifests would be tracked in https://github.com/openshift/okd-machine-os

Tests and builds would be added in openshift/release#14082.
openshift/enhancements#78

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2020
@vrutkovs
Copy link
Member Author

vrutkovs commented Dec 4, 2020

/cc @smarterclayton @abhinavdahiya

@vrutkovs vrutkovs changed the title pkg/types/installconfig: add IsOKD function and OKD build tag Add OKD installer images Dec 4, 2020
@vrutkovs
Copy link
Member Author

vrutkovs commented Dec 4, 2020

/hold

installer team needs to agree if the approach is right

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 4, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2020
@vrutkovs vrutkovs force-pushed the fcos-4.7-devel branch 2 times, most recently from 2a159c2 to 181f519 Compare December 16, 2020 11:57
@vrutkovs
Copy link
Member Author

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 16, 2020 •
edited
Loading

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 181f51949e1734f9920e4d17d27af9bbeeb074f0 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs force-pushed the fcos-4.7-devel branch 2 times, most recently from 906fd23 to 689f664 Compare December 19, 2020 08:32
@patrickdillon
Copy link
Contributor

cc @staebler

@LorbusChris LorbusChris mentioned this pull request Dec 21, 2020
Merged
@vrutkovs vrutkovs mentioned this pull request Jan 12, 2021
Merged
@vrutkovs vrutkovs force-pushed the fcos-4.7-devel branch 4 times, most recently from 82addf8 to 6dd395f Compare January 23, 2021 23:26
@vrutkovs
Copy link
Member Author

/hold cancel
ready for review

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2021
@jstuever
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2021
@jstuever
Copy link
Contributor

/retest

@jstuever
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2021 •
edited
Loading

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-kuryr e7170db link /test e2e-openstack-kuryr
ci/prow/e2e-libvirt e7170db link /test e2e-libvirt
ci/prow/e2e-crc e7170db link /test e2e-crc
ci/prow/e2e-aws-workers-rhel7 e7170db link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fe9336b into openshift:master Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staebler staebler staebler left review comments

@LorbusChris LorbusChris LorbusChris left review comments

@cgwalters cgwalters cgwalters approved these changes

@iamemilio iamemilio Awaiting requested review from iamemilio

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@jstuever jstuever

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@vrutkovs @openshift-merge-robot @patrickdillon @openshift-ci-robot @ashcrow @staebler @jstuever @openshift-bot @cgwalters @LorbusChris