Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17157: operator-registry: cherry-pick to be up-to-date #526

Merged
merged 5 commits into from
Aug 2, 2023
Merged

OCPBUGS-17157: operator-registry: cherry-pick to be up-to-date #526

merged 5 commits into from
Aug 2, 2023

Conversation

stevekuznetsov
Copy link
Contributor

No description provided.

@stevekuznetsov stevekuznetsov force-pushed the skuznets/cherry-pick-mmemory branch 2 times, most recently from 650c4e2 to 1380503 Compare July 31, 2023 14:25
@stevekuznetsov
Copy link
Contributor Author

The make target succeeds for me locally - would appreciate some guidance here.

acornett21 and others added 3 commits July 31, 2023 11:09
@acornett21 @stevekuznetsov
updating operator-framework/api dependency which has k8s 1.27 changes…
02581e7 
… (#1120)

Signed-off-by: Adam D. Cornett <[email protected]>

Upstream-repository: operator-registry

Upstream-commit: 82a91fa2bf806d06c11454e1123cc97e60aed22a
@rashmigottipati @stevekuznetsov
(plain bundle usage) Documentation on how to add a plain bundle image…
1e121b5 
… to a file-based catalog (#1127)

* Documentation on how to add a plain bundle to a file-based catalog

Signed-off-by: Rashmi Gottipati <[email protected]>

* Address review feedback

Signed-off-by: Rashmi Gottipati <[email protected]>

* Clarify regular bundle to be of registry+v1 format

Signed-off-by: Rashmi Gottipati <[email protected]>

* Address review feedback openshift#1

Signed-off-by: Rashmi Gottipati <[email protected]>

* Address review feedback openshift#2

Signed-off-by: Rashmi Gottipati <[email protected]>

* Address review feedback openshift#3

Signed-off-by: Rashmi Gottipati <[email protected]>

* Add an example for the desired channel name and link to OLM best practices for channel naming conventions

Signed-off-by: Rashmi Gottipati <[email protected]>

---------

Signed-off-by: Rashmi Gottipati <[email protected]>

Upstream-repository: operator-registry

Upstream-commit: bca2bfb89bc4db7bd9ebd08031be3d59bfdc65e8
@m1kola @stevekuznetsov
Makes codecov-action optional (#1130)
6cd4f91 
We do not want to fail the job if codecov fails
to upload the report due to rate limiting.

Signed-off-by: Mikalai Radchuk <[email protected]>

Upstream-repository: operator-registry

Upstream-commit: 52190e4d4699b01a5ee5c33caff9b280038194d8
@stevekuznetsov
opm: always serve pprof endpoints, improve server allocations (#1129)
24fe55c 
* pkg/cache: use a shared buffer to limit allocations

Previously, new buffers were allocated on each file we read in, which
was unnecessary and wasteful.

Signed-off-by: Steve Kuznetsov <[email protected]>

* cmd/opm: serve pprof endpoints by default

There is no substantial runtime cost to serving pprof endpoints, and
when things hit the fan and we need to investigate performance in situ,
there is no time to restart pods and change flags. Capturing profiles
remains opt-in, since those are costly.

Signed-off-by: Steve Kuznetsov <[email protected]>

---------

Signed-off-by: Steve Kuznetsov <[email protected]>

Upstream-repository: operator-registry

Upstream-commit: 68e13df96590977370ffcd1a8e9ff76e0f2a03f2
Signed-off-by: Steve Kuznetsov <[email protected]>
grokspawn
grokspawn reviewed Aug 1, 2023
View reviewed changes
pkg/manifests/csv.yaml Outdated Show resolved Hide resolved
@stevekuznetsov
go.mod: update API to latest tag (#1131)
41dc379 
```
export GOPROXY=direct
go get github.com/operator-framework/[email protected]
go mod tidy
```

Signed-off-by: Steve Kuznetsov <[email protected]>

Upstream-repository: operator-registry

Upstream-commit: 5ecb013fb51897f6962a7c7560a38e221f0c1902
Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov stevekuznetsov changed the title operator-registry: cherry-pick to be up-to-date OCPBUGS-17157: operator-registry: cherry-pick to be up-to-date Aug 1, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 1, 2023
@openshift-ci-robot
Copy link

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 1, 2023
Merged
Merged
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9a977fa and 2 for PR HEAD 41dc379 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d5108bd and 1 for PR HEAD 41dc379 in total

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 2, 2023
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6413915 and 0 for PR HEAD 41dc379 in total

@stevekuznetsov stevekuznetsov mentioned this pull request Aug 2, 2023
Closed
38 tasks
@tmshort
Copy link
Contributor

tmshort commented Aug 2, 2023

Noting that I see go.mod + vendor changes, but not go.sum; presumably since ci/prow/verify passed, the checksum was already there.
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d98ec8b into openshift:master Aug 2, 2023
@openshift-ci-robot
Copy link

@stevekuznetsov: Jira Issue OCPBUGS-17157: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-17157 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 3, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 15, 2023
Merged
This was referenced Aug 15, 2023
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 24, 2023
Merged
This was referenced Sep 5, 2023
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 18, 2023
Merged
This was referenced Sep 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmshort tmshort tmshort left review comments

@grokspawn grokspawn grokspawn approved these changes

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@tmshort tmshort

@grokspawn grokspawn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@stevekuznetsov @openshift-ci-robot @tmshort @grokspawn @openshift-merge-robot @acornett21 @rashmigottipati @m1kola