Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17157: registry: implement memory targets on gRPC servers #3004

Conversation

stevekuznetsov
Copy link
Member

go.mod: update operator-framework/api

$ GOPROXY=direct go get github.com/operator-framework/api@master
$ GOPROXY=direct go mod tidy
$ GOPROXY=direct go mod vendor
$ make gen-all

Signed-off-by: Steve Kuznetsov [email protected]


registry: implement memory targets on gRPC servers

This commit implements the GoDoc on the new CatalogSource field, adding
memory requests, limits and $GOMEMLIMIT values for sources that opt into
a memory target.

Signed-off-by: Steve Kuznetsov [email protected]


   $ GOPROXY=direct go get github.com/operator-framework/api@master
   $ GOPROXY=direct go mod tidy
   $ GOPROXY=direct go mod vendor
   $ make gen-all

Signed-off-by: Steve Kuznetsov <[email protected]>
This commit implements the GoDoc on the new CatalogSource field, adding
memory requests, limits and $GOMEMLIMIT values for sources that opt into
a memory target.

Signed-off-by: Steve Kuznetsov <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 3, 2023
@openshift-ci-robot
Copy link
Collaborator

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

go.mod: update operator-framework/api

$ GOPROXY=direct go get github.com/operator-framework/api@master
$ GOPROXY=direct go mod tidy
$ GOPROXY=direct go mod vendor
$ make gen-all

Signed-off-by: Steve Kuznetsov [email protected]


registry: implement memory targets on gRPC servers

This commit implements the GoDoc on the new CatalogSource field, adding
memory requests, limits and $GOMEMLIMIT values for sources that opt into
a memory target.

Signed-off-by: Steve Kuznetsov [email protected]


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2c3928e into operator-framework:master Aug 3, 2023
15 checks passed
@openshift-ci-robot
Copy link
Collaborator

@stevekuznetsov: Jira Issue OCPBUGS-17157: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-17157 has not been moved to the MODIFIED state.

In response to this:

go.mod: update operator-framework/api

$ GOPROXY=direct go get github.com/operator-framework/api@master
$ GOPROXY=direct go mod tidy
$ GOPROXY=direct go mod vendor
$ make gen-all

Signed-off-by: Steve Kuznetsov [email protected]


registry: implement memory targets on gRPC servers

This commit implements the GoDoc on the new CatalogSource field, adding
memory requests, limits and $GOMEMLIMIT values for sources that opt into
a memory target.

Signed-off-by: Steve Kuznetsov [email protected]


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants