-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds guide for adding a hint file to the node ip configuration #52200
Conversation
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/5597 |
Linking back to old nodeip doc BZ https://bugzilla.redhat.com/show_bug.cgi?id=2105010 This should eventually resolve it. |
Oh wow, I completely forgot I opened that. Maybe we should just remove the old method then and rely on the new override mechanism. We can always revisit this if it turns out that the new method is insufficient for someone. |
To be sure, we're talking about removing the entirety of "How the network interface is selected", correct? |
No, we still need this section to discuss the new method. However, I think we should remove everything from "In some situations, creating a hint file might be insufficient..." on. Also, looking at this in context a bit more I'm realizing that some of the other parts should be changed. For example, "The service iterates through the network interfaces on the node and the first network interface that is configured with a subnet than can host the IP address for the API server is selected for {product-title} communication." is describing the IPI behavior, which we do not support overriding because it breaks connectivity to the VIPs. It should say that nodeip-configuration selects the IP from the interface associated with the default route. This is also not only relevant in case of hardware or networking changes. This is needed any time there is a networking layout where the node ip should not come from the default route interface, which is more commonly going to happen on day 1. It appears I did not review this documentation carefully enough when it was first added. :-/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, we still have some issues here. I left some comments inline, but overall they boil down to this should be included in the UPI docs but not the IPI docs, and it shouldn't be necessary to write a procedure to determine the available address ranges because those have to be provided as part of the installation regardless of whether you do this or not. If we just remove that section entirely a lot of the problems I noted go away.
30eb19a
to
a49947a
Compare
@rbbratta @cybertron please take a look. I have made all request changes, including to the procedure and location of the docs. Thanks. |
a49947a
to
0def947
Compare
/lgtm |
/lgtm |
0def947
to
d24a8bc
Compare
/lgtm |
Updates the proc that may not be needed
d24a8bc
to
d83ac40
Compare
New changes are detected. LGTM label has been removed. |
Adds guide for adding a hint file to the node ip configuration
4.12
Issue:
https://issues.redhat.com/browse/OPNET-150 / https://issues.redhat.com/browse/OSDOCS-4376
Link to docs preview:
Release note: https://52200--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html#ocp-4-12-networking
Troubleshooting: https://52200--docspreview.netlify.app/openshift-enterprise/latest/support/troubleshooting/troubleshooting-network-issues.html#nw-how-nw-iface-selected_troubleshooting-network-issues
QE review:
Pending QE/SME
Original PR at #51816. Has received SME ack.