Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds procedure and work for adding a hint file to the node IP configu… #53986

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Adds procedure and work for adding a hint file to the node IP configu… #53986

merged 1 commit into from
Dec 19, 2022

Conversation

stevsmit
Copy link
Member

@stevsmit stevsmit commented Dec 19, 2022 •
edited
Loading

@stevsmit stevsmit added this to the Planned for 4.12 GA milestone Dec 19, 2022
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 19, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 19, 2022 •
edited
Loading

🤖 Updated build preview is available at:
https://53986--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/5619

@stevsmit stevsmit added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 19, 2022
@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Dec 19, 2022
jeana-redhat
jeana-redhat reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little suggestions from me, looks good!

modules/nw-how-nw-iface-selected.adoc Outdated Show resolved Hide resolved
modules/nw-how-nw-iface-selected.adoc Outdated Show resolved Hide resolved
modules/overriding-default-node-ip-selection-logic.adoc Outdated Show resolved Hide resolved
modules/overriding-default-node-ip-selection-logic.adoc Outdated Show resolved Hide resolved
modules/overriding-default-node-ip-selection-logic.adoc Outdated Show resolved Hide resolved
modules/overriding-default-node-ip-selection-logic.adoc Outdated Show resolved Hide resolved
modules/overriding-default-node-ip-selection-logic.adoc Show resolved Hide resolved
@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 19, 2022
@stevsmit stevsmit added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 19, 2022
@mburke5678 mburke5678 merged commit f390859 into openshift:main Dec 19, 2022
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 19, 2022
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 19, 2022
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #54015

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeana-redhat jeana-redhat jeana-redhat left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.12 GA
Development

Successfully merging this pull request may close these issues.
5 participants
@stevsmit @ocpdocs-previewbot @mburke5678 @openshift-cherrypick-robot @jeana-redhat