Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.17] OCPBUGS-42949: add tag matching to Azure File storage class #291

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from

Commits on Oct 9, 2024

  1. add tag matching to Azure File storage class

    Adding the tags should ensure that we do not match a storage account
    that was created by someone else which would be undesirable.
    
    Additionally it solves the problem of matching storage accounts with
    private endpoints - currently driver can match those even if
    `networkEndpointType` is unset. Using the tags and matching should make
    this more predictable and driver should no longer match those.
    However, even if this ever gets fixed, we should probably still keep
    the tags to prevent matching "foreign" storage accounts.
    
    Upstream issue: kubernetes-sigs/azurefile-csi-driver#2085
    RomanBednar authored and openshift-cherrypick-robot committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f4a35ef View commit details
    Browse the repository at this point in the history