Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-42949: add tag matching to Azure File storage class #291

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-42949: add tag matching to Azure File storage class #291

wants to merge 1 commit into from
+6 −0

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #272

/assign RomanBednar

@RomanBednar
add tag matching to Azure File storage class
f4a35ef 
Adding the tags should ensure that we do not match a storage account
that was created by someone else which would be undesirable.

Additionally it solves the problem of matching storage accounts with
private endpoints - currently driver can match those even if
`networkEndpointType` is unset. Using the tags and matching should make
this more predictable and driver should no longer match those.
However, even if this ever gets fixed, we should probably still keep
the tags to prevent matching "foreign" storage accounts.

Upstream issue: kubernetes-sigs/azurefile-csi-driver#2085
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2024
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from romanbednar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-38922 has been cloned as Jira Issue OCPBUGS-42949. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-42949: add tag matching to Azure File storage class

In response to this:

This is an automated cherry-pick of #272

/assign RomanBednar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-38922: add tag matching to Azure File storage class [release-4.17] OCPBUGS-42949: add tag matching to Azure File storage class Oct 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 9, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42949, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-38922 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #272

/assign RomanBednar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024 •
edited
Loading

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi f4a35ef link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@duanwei33
Copy link

/retest e2e-azure-csi-extended

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

@duanwei33: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test aws-efs-operator-e2e
  • /test ci-index-aws-efs-csi-driver-operator-bundle
  • /test ci-index-smb-csi-driver-operator-bundle
  • /test e2e-aws-csi
  • /test e2e-aws-ovn-upgrade
  • /test e2e-azure
  • /test e2e-azure-csi
  • /test e2e-azure-file-csi
  • /test e2e-azure-file-nfs-csi
  • /test e2e-azure-ovn-upgrade
  • /test hypershift-aws-e2e-external
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test aws-efs-operator-e2e-extended
  • /test e2e-aws-csi-extended
  • /test e2e-azure-csi-extended
  • /test e2e-azure-file-csi-extended
  • /test e2e-azure-manual-oidc
  • /test e2e-azurestack-csi
  • /test okd-scos-images
  • /test security
  • /test smb-operator-e2e
  • /test smb-operator-e2e-extended

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-csi-operator-release-4.17-aws-efs-operator-e2e
  • pull-ci-openshift-csi-operator-release-4.17-aws-efs-operator-e2e-extended
  • pull-ci-openshift-csi-operator-release-4.17-ci-index-aws-efs-csi-driver-operator-bundle
  • pull-ci-openshift-csi-operator-release-4.17-ci-index-smb-csi-driver-operator-bundle
  • pull-ci-openshift-csi-operator-release-4.17-e2e-aws-csi
  • pull-ci-openshift-csi-operator-release-4.17-e2e-aws-csi-extended
  • pull-ci-openshift-csi-operator-release-4.17-e2e-aws-ovn-upgrade
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-csi
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-csi-extended
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-file-csi
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-file-csi-extended
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-file-nfs-csi
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-ovn-upgrade
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azurestack-csi
  • pull-ci-openshift-csi-operator-release-4.17-hypershift-aws-e2e-external
  • pull-ci-openshift-csi-operator-release-4.17-images
  • pull-ci-openshift-csi-operator-release-4.17-security
  • pull-ci-openshift-csi-operator-release-4.17-smb-operator-e2e
  • pull-ci-openshift-csi-operator-release-4.17-smb-operator-e2e-extended
  • pull-ci-openshift-csi-operator-release-4.17-unit
  • pull-ci-openshift-csi-operator-release-4.17-verify
  • pull-ci-openshift-csi-operator-release-4.17-verify-deps

In response to this:

/retest e2e-azure-csi-extended

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@duanwei33
Copy link

Testing with the open PR:

  • For new installation, the sc azurefile-csi with “tags” and “matchTags” is created, the provisioning and all other features like rezise/clone/snapshot works.
  • Install a 4.16 cluster (without the fix yet), create PVCs with sc azurefile-csi which don’t have the “tags” and “match Tags”, then upgrade to 4.17 with [release-4.17] OCPBUGS-42949: add tag matching to Azure File storage class #291, after upgrading, the azurefile-csi sc name is still the same but the content changes, the “tags” and and “match Tags” are added. CSI Driver can still manage the previous PVCs created in 4.16 well like resize/clone/delete, so it should not impact the upgrade.

@duanwei33
Copy link

/test e2e-azure-csi-extended

@duanwei33
Copy link

/retest required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

@duanwei33: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test aws-efs-operator-e2e
  • /test ci-index-aws-efs-csi-driver-operator-bundle
  • /test ci-index-smb-csi-driver-operator-bundle
  • /test e2e-aws-csi
  • /test e2e-aws-ovn-upgrade
  • /test e2e-azure
  • /test e2e-azure-csi
  • /test e2e-azure-file-csi
  • /test e2e-azure-file-nfs-csi
  • /test e2e-azure-ovn-upgrade
  • /test hypershift-aws-e2e-external
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test aws-efs-operator-e2e-extended
  • /test e2e-aws-csi-extended
  • /test e2e-azure-csi-extended
  • /test e2e-azure-file-csi-extended
  • /test e2e-azure-manual-oidc
  • /test e2e-azurestack-csi
  • /test okd-scos-images
  • /test security
  • /test smb-operator-e2e
  • /test smb-operator-e2e-extended

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-csi-operator-release-4.17-aws-efs-operator-e2e
  • pull-ci-openshift-csi-operator-release-4.17-aws-efs-operator-e2e-extended
  • pull-ci-openshift-csi-operator-release-4.17-ci-index-aws-efs-csi-driver-operator-bundle
  • pull-ci-openshift-csi-operator-release-4.17-ci-index-smb-csi-driver-operator-bundle
  • pull-ci-openshift-csi-operator-release-4.17-e2e-aws-csi
  • pull-ci-openshift-csi-operator-release-4.17-e2e-aws-csi-extended
  • pull-ci-openshift-csi-operator-release-4.17-e2e-aws-ovn-upgrade
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-csi
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-csi-extended
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-file-csi
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-file-csi-extended
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-file-nfs-csi
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azure-ovn-upgrade
  • pull-ci-openshift-csi-operator-release-4.17-e2e-azurestack-csi
  • pull-ci-openshift-csi-operator-release-4.17-hypershift-aws-e2e-external
  • pull-ci-openshift-csi-operator-release-4.17-images
  • pull-ci-openshift-csi-operator-release-4.17-security
  • pull-ci-openshift-csi-operator-release-4.17-smb-operator-e2e
  • pull-ci-openshift-csi-operator-release-4.17-smb-operator-e2e-extended
  • pull-ci-openshift-csi-operator-release-4.17-unit
  • pull-ci-openshift-csi-operator-release-4.17-verify
  • pull-ci-openshift-csi-operator-release-4.17-verify-deps

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@duanwei33
Copy link

/test e2e-azure

@duanwei33
Copy link

/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Oct 11, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42949, which is invalid:

  • expected dependent Jira Issue OCPBUGS-38922 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #272

/assign RomanBednar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RomanBednar
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 22, 2024
@openshift-ci-robot
Copy link

@RomanBednar: This pull request references Jira Issue OCPBUGS-42949, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-38922 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-38922 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RomanBednar
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 22, 2024
@RomanBednar
Copy link
Contributor

cc @openshift/storage for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@RomanBednar RomanBednar

@chao007 chao007

@duanwei33 duanwei33

@ropatil010 ropatil010

@Phaow Phaow

@radeore radeore

Labels
backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @duanwei33 @RomanBednar @chao007 @ropatil010 @Phaow @radeore