-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop Streaming Jobs When datasource is disabled/deleted. #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmmusings
added
backport 2.x
enhancement
New feature or request
v2.13.0
Issues targeting release v2.13.0
labels
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2559 +/- ##
============================================
- Coverage 95.50% 95.40% -0.11%
- Complexity 5117 5129 +12
============================================
Files 489 490 +1
Lines 14318 14412 +94
Branches 963 965 +2
============================================
+ Hits 13675 13750 +75
- Misses 618 637 +19
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vmmusings
force-pushed
the
ss-jobs
branch
3 times, most recently
from
March 18, 2024 23:24
ac8e5ce
to
c763d2b
Compare
penghuo
reviewed
Mar 19, 2024
spark/src/main/java/org/opensearch/sql/spark/cluster/FlintStreamingJobCleanerTask.java
Outdated
Show resolved
Hide resolved
vmmusings
force-pushed
the
ss-jobs
branch
5 times, most recently
from
March 19, 2024 07:56
400223a
to
fc0e579
Compare
vmmusings
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey and
acarbonetto
as code owners
March 19, 2024 07:59
dai-chen
reviewed
Mar 19, 2024
spark/src/main/java/org/opensearch/sql/spark/cluster/FlintStreamingJobCleanerTask.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Mar 19, 2024
spark/src/main/java/org/opensearch/sql/spark/cluster/FlintStreamingJobCleanerTask.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/cluster/FlintStreamingJobCleanerTask.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Mar 19, 2024
spark/src/main/java/org/opensearch/sql/spark/cluster/FlintStreamingJobCleanerTask.java
Outdated
Show resolved
Hide resolved
penghuo
reviewed
Mar 19, 2024
spark/src/main/java/org/opensearch/sql/spark/cluster/ClusterManagerEventListener.java
Outdated
Show resolved
Hide resolved
vmmusings
force-pushed
the
ss-jobs
branch
5 times, most recently
from
March 19, 2024 20:35
0ca186e
to
309a0a7
Compare
vmmusings
commented
Mar 19, 2024
spark/src/main/java/org/opensearch/sql/spark/cluster/FlintStreamingJobHouseKeeperTask.java
Outdated
Show resolved
Hide resolved
seankao-az
previously approved these changes
Mar 19, 2024
vmmusings
force-pushed
the
ss-jobs
branch
2 times, most recently
from
March 19, 2024 21:25
8b6975e
to
31dc0c2
Compare
Signed-off-by: Vamsi Manohar <[email protected]>
seankao-az
approved these changes
Mar 19, 2024
rupal-bq
approved these changes
Mar 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit b3fc1ca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings
pushed a commit
that referenced
this pull request
Mar 19, 2024
(cherry picked from commit b3fc1ca) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation: https://github.com/vamsi-amazon/sql/blob/ss-jobs/docs/user/admin/settings.rst#pluginsqueryexecutionenginesparkstreamingjobshousekeeperinterval
Testing
Stats API with new metric.
Verified Interval Change effect on cron task.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.