Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Stop Streaming Jobs When datasource is disabled/deleted. #2567

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[Backport 2.x] Stop Streaming Jobs When datasource is disabled/deleted. #2567

merged 1 commit into from
Mar 19, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b3fc1ca from #2559.

@github-actions
FlintStreamingJobCleanerTask Implementation (#2559)
2695ae5 
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit b3fc1ca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.94737% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 95.45%. Comparing base (59875d8) to head (2695ae5).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...sql/spark/cluster/ClusterManagerEventListener.java 0.00% 20 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x    #2567      +/-   ##
============================================
- Coverage     95.56%   95.45%   -0.11%     
- Complexity     5154     5166      +12     
============================================
  Files           490      491       +1     
  Lines         14483    14577      +94     
  Branches        966      968       +2     
============================================
+ Hits          13840    13915      +75     
- Misses          618      637      +19     
  Partials         25       25
Flag Coverage Δ
sql-engine 95.45% <78.94%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vamsimanohar
Copy link
Member

most of the failures are in uploading artificats. Merging the PR.

@vamsimanohar vamsimanohar merged commit b4c5415 into 2.x Mar 19, 2024
28 of 39 checks passed
@github-actions github-actions bot deleted the backport/backport-2559-to-2.x branch March 19, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vamsimanohar vamsimanohar vamsimanohar approved these changes

@rupal-bq rupal-bq rupal-bq approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vamsimanohar @YANG-DB @rupal-bq