Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unit tests for FlintIndexReader #2238

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

vmmusings
Copy link
Member

Description

  • Fixed Unit tests in FlintIndexReader.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2238 (7788d8a) into main (492982c) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2238      +/-   ##
============================================
+ Coverage     96.35%   96.59%   +0.23%     
- Complexity     4725     4730       +5     
============================================
  Files           439      439              
  Lines         12691    12691              
  Branches        871      871              
============================================
+ Hits          12229    12259      +30     
+ Misses          454      424      -30     
  Partials          8        8              
Flag Coverage Δ
sql-engine 96.59% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../sql/spark/flint/FlintIndexMetadataReaderImpl.java 100.00% <100.00%> (+100.00%) ⬆️
...org/opensearch/sql/spark/flint/FlintIndexType.java 100.00% <100.00%> (+12.50%) ⬆️

@vmmusings vmmusings merged commit 55e8e84 into opensearch-project:main Oct 6, 2023
24 of 25 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 55e8e84)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.11
# Create a new branch
git switch --create backport/backport-2238-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 55e8e841c8bf69a924bed2c735fc47554c111ac4
# Push it to GitHub
git push --set-upstream origin backport/backport-2238-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport/backport-2238-to-2.11.

vmmusings pushed a commit that referenced this pull request Oct 6, 2023
(cherry picked from commit 55e8e84)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
(cherry picked from commit 55e8e84)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 3297502)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 55e8e84)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.11 bug Something isn't working Flint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants