Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix Unit tests for FlintIndexReader #2239

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 55e8e84 from #2238.

Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 55e8e84)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2239 (014cc97) into 2.x (6b221c3) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #2239      +/-   ##
============================================
+ Coverage     96.40%   96.64%   +0.23%     
- Complexity     4762     4767       +5     
============================================
  Files           440      440              
  Lines         12858    12858              
  Branches        874      874              
============================================
+ Hits          12396    12426      +30     
+ Misses          454      424      -30     
  Partials          8        8              
Flag Coverage Δ
sql-engine 96.64% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../sql/spark/flint/FlintIndexMetadataReaderImpl.java 100.00% <100.00%> (+100.00%) ⬆️
...org/opensearch/sql/spark/flint/FlintIndexType.java 100.00% <100.00%> (+12.50%) ⬆️

Copy link
Collaborator

@anirudha anirudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vmmusings vmmusings merged commit 3297502 into 2.x Oct 6, 2023
28 of 29 checks passed
@github-actions github-actions bot deleted the backport/backport-2238-to-2.x branch October 6, 2023 04:59
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
(cherry picked from commit 55e8e84)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 3297502)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants