Fix JwtAuthenticationTests.shouldAuthenticateWithJwtToken_positive assertion #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
Looking into this error |
peternied
approved these changes
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #2844 +/- ##
============================================
- Coverage 61.60% 61.59% -0.02%
+ Complexity 3414 3412 -2
============================================
Files 266 266
Lines 18917 18917
Branches 3303 3303
============================================
- Hits 11653 11651 -2
Misses 5669 5669
- Partials 1595 1597 +2 |
RyanL1997
approved these changes
Jun 8, 2023
Hey @cwperks, the error is related to this change: opensearch-project/OpenSearch#7646 |
DarshitChanpura
approved these changes
Jun 9, 2023
RyanL1997
pushed a commit
to RyanL1997/security
that referenced
this pull request
Jun 13, 2023
Signed-off-by: Craig Perkins <[email protected]>
This was referenced Jun 13, 2023
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
Signed-off-by: Craig Perkins <[email protected]>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Sam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes an assertion in
JwtAuthenticationTests.shouldAuthenticateWithJwtToken_positivethat was not testing the code correctly. It was checking if a variable was equal to itself instead of the actual expected value.Test fix
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.