Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync up security/extensions feature branch with main on 06/13/2023 #2853

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Jun 13, 2023

Description

Sync up security/extensions feature branch with main on 06/13/2023

This PR includes following changes in main branch through May 25 - Jun 13:

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ylwu-amzn and others added 10 commits June 13, 2023 10:29
…w has one. (opensearch-project#2801)

This resolves "JAR hell" issues when installing the plugin.

Signed-off-by: Thomas Farr <[email protected]>
…ject#2808)

* [FEATURE] usage of JWKS with JWT (w/o OpenID connect)

Signed-off-by: Sebastian Michalski <[email protected]>

* Change issuer to audience

Signed-off-by: Craig Perkins <[email protected]>

* Switch to OCT_2 and use String instead of var

Signed-off-by: Craig Perkins <[email protected]>

* Only check required issuer and required audience if set

Signed-off-by: Craig Perkins <[email protected]>

* Fix test cases

Signed-off-by: Craig Perkins <[email protected]>

* Remove unused import

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Sebastian Michalski <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Sebastian Michalski <[email protected]>
* Isolate spotless config changes

Signed-off-by: Craig Perkins <[email protected]>

* update dlic/auth package style

Signed-off-by: Stephen Crawford <[email protected]>

* Update formatterConfig.xml

---------

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
* Match version of zstd-jni from core

Signed-off-by: Craig Perkins <[email protected]>

* Add zstd version from core to force resolutions section

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
…t#2843)

* Add Andrey to Maintainers

Signed-off-by: Stephen Crawford <[email protected]>

* Update MAINTAINERS.md

Signed-off-by: Stephen Crawford <[email protected]>

* Update codeowners

Signed-off-by: Stephen Crawford <[email protected]>

---------

Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@peternied
Copy link
Member

@RyanL1997 Feel free to merge whenever you are ready

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #2853 (340d17b) into feature/extensions (56e77fe) will increase coverage by 0.17%.
The diff coverage is 71.62%.

@@                   Coverage Diff                    @@
##             feature/extensions    #2853      +/-   ##
========================================================
+ Coverage                 61.49%   61.67%   +0.17%     
- Complexity                 3428     3443      +15     
========================================================
  Files                       269      269              
  Lines                     19096    19124      +28     
  Branches                   3327     3330       +3     
========================================================
+ Hits                      11744    11794      +50     
+ Misses                     5740     5720      -20     
+ Partials                   1612     1610       -2     
Impacted Files Coverage Δ
.../main/java/com/amazon/dlic/auth/ldap/LdapUser.java 85.71% <ø> (ø)
...c/auth/ldap/backend/LDAPAuthenticationBackend.java 81.73% <ø> (ø)
...ic/auth/ldap/backend/LDAPAuthorizationBackend.java 57.81% <ø> (ø)
...on/dlic/auth/ldap2/LDAPAuthenticationBackend2.java 67.96% <ø> (ø)
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <ø> (ø)
...a/org/opensearch/security/DefaultObjectMapper.java 64.55% <ø> (ø)
.../opensearch/security/OpenSearchSecurityPlugin.java 80.31% <ø> (ø)
.../action/configupdate/ConfigUpdateNodeResponse.java 77.27% <ø> (ø)
...tion/configupdate/TransportConfigUpdateAction.java 100.00% <ø> (ø)
.../security/action/whoami/TransportWhoAmIAction.java 33.33% <0.00%> (ø)
... and 107 more

... and 3 files with indirect coverage changes

@RyanL1997
Copy link
Collaborator Author

Closing this since this #2854 included the latest changes got merged 1 hour ago..

@RyanL1997 RyanL1997 closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants