Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the "Blacklist / Whitelist" nomenclature #1665

Closed
Tracked by #2589 ...
tlfeng opened this issue Mar 5, 2022 · 3 comments · Fixed by #2056
Closed
Tracked by #2589 ...

Deprecate the "Blacklist / Whitelist" nomenclature #1665

tlfeng opened this issue Mar 5, 2022 · 3 comments · Fixed by #2056
Assignees
Labels
enhancement New feature or request v2.1.0

Comments

@tlfeng
Copy link

tlfeng commented Mar 5, 2022

Is your feature request related to a problem? Please describe.
OpenSearch repository is going to replace the terminology "blacklist / whitelist" with "denylist / allowlist".
issue: opensearch-project/OpenSearch#1483, with the plan for its terminology replacement.

Although the existing usages with "blacklist / whitelist" will be supported in OpenSearch version 2.x until further notice to keep the backwards compatibility, it's suggested to prepare for the nomenclature change in advance, and replace all the usages with "blacklist / whitelist" terminology in the code base.

Describe the solution you'd like
Replace the terminology "blacklist / whitelist" with "denylist / allowlist".

When being compatible with OpenSearch 2.0:

  • Replace "whitelist" in code comment and internal method / class name.
  • Replace "whitelist" in REST API and Setting
  • Replace "whitelist" in documentation

Specifically,

Describe alternatives you've considered
None.

Additional context
An existing PR: #1560

@tlfeng tlfeng added the enhancement New feature or request label Mar 5, 2022
@dblock dblock changed the title Change the "Blacklist / Whitelist" nomenclature Deprecate the "Blacklist / Whitelist" nomenclature Apr 18, 2022
@peternied peternied removed the v2.0.0 label Apr 27, 2022
@peternied
Copy link
Member

Deprecate did not make it in time for the v2.0.0 release, it will be targeted for v2.1.0

@davidlago
Copy link

Talked to @cliu123 offline, he is working on this and we are still targeting 2.0 GA.

@davidlago davidlago added v2.0.0 and removed v2.1.0 labels Apr 28, 2022
@peternied peternied added v2.0.0-GeneralAvailability For changes that should only be included in the 2.0.0-GA release and removed v2.0.0 labels Apr 28, 2022
@cliu123
Copy link
Member

cliu123 commented May 12, 2022

Closing with merging #1808.

@cliu123 cliu123 closed this as completed May 12, 2022
@cliu123 cliu123 added v2.1.0 and removed v2.0.0-GeneralAvailability For changes that should only be included in the 2.0.0-GA release labels May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants