Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the inconsistent variable for DLS #2056

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Aug 29, 2022

Signed-off-by: Ryan Liang [email protected]

Description

Fixed the inconsistent variable with name "documentWhitelist" and changed it into "documentAllowlist" with all its references in DlsFilterLevelActionHandler.java.

Issues Resolved

Resolve #1665

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997 RyanL1997 marked this pull request as ready for review August 29, 2022 21:06
@RyanL1997 RyanL1997 requested a review from a team August 29, 2022 21:06
@peternied peternied merged commit 1efc512 into opensearch-project:main Aug 30, 2022
@cwperks
Copy link
Member

cwperks commented Sep 8, 2022

@cliu123 Can we backport this to 2.x?

@peternied peternied added the backport 2.x backport to 2.x branch label Sep 8, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2022
Signed-off-by: Ryan Liang <[email protected]>

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 1efc512)
cwperks pushed a commit that referenced this pull request Sep 8, 2022
Signed-off-by: Ryan Liang <[email protected]>

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 1efc512)

Co-authored-by: Ryan Liang <[email protected]>
@dreamer-89
Copy link
Member

@cliu123 @cwperks : As this change is also related to inclusive naming, do we need to backport to remaining 2.x branches (2.0, 2.1, 2.2, 2.3) ?

@cwperks
Copy link
Member

cwperks commented Sep 13, 2022

@dreamer-89 This change does not need to be backported. I'm not sure if there is a formal backporting policy written down anywhere, but in general I believe any dependency upgrades (especially those with security fixes) and requested bugfixes are backported.

@peternied
Copy link
Member

Backporting process is documented here https://github.com/opensearch-project/.github/blob/main/RELEASING.md#backporting

stephen-crawford pushed a commit to stephen-crawford/security that referenced this pull request Nov 10, 2022
Signed-off-by: Ryan Liang <[email protected]>

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
…search-project#2083)

Signed-off-by: Ryan Liang <[email protected]>

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 1efc512)

Co-authored-by: Ryan Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the "Blacklist / Whitelist" nomenclature
5 participants