Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename whitelist api and setting #1835

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented May 11, 2022

Description

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Refactoring

Issues Resolved

#1665

Testing

UTs

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cliu123 cliu123 requested a review from a team May 11, 2022 06:26
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #1835 (18c26c3) into main (ad90eff) will decrease coverage by 0.01%.
The diff coverage is 55.81%.

@@             Coverage Diff              @@
##               main    #1835      +/-   ##
============================================
- Coverage     60.82%   60.81%   -0.02%     
  Complexity     3187     3187              
============================================
  Files           253      253              
  Lines         17943    17943              
  Branches       3205     3205              
============================================
- Hits          10914    10912       -2     
- Misses         5452     5453       +1     
- Partials       1577     1578       +1     
Impacted Files Coverage Δ
...earch/security/dlic/rest/api/MigrateApiAction.java 4.16% <0.00%> (ø)
...urity/dlic/rest/validation/AllowlistValidator.java 100.00% <ø> (ø)
...rg/opensearch/security/securityconf/Migration.java 57.65% <0.00%> (ø)
...a/org/opensearch/security/tools/SecurityAdmin.java 37.74% <0.00%> (+0.24%) ⬆️
...curity/securityconf/impl/AllowlistingSettings.java 80.00% <42.85%> (ø)
...ity/configuration/DlsFilterLevelActionHandler.java 55.27% <66.66%> (ø)
...ch/security/securityconf/DynamicConfigFactory.java 55.26% <80.00%> (ø)
...ty/configuration/ConfigurationLoaderSecurity7.java 65.57% <100.00%> (ø)
...ecurity/configuration/ConfigurationRepository.java 71.97% <100.00%> (ø)
...rch/security/dlic/rest/api/AllowlistApiAction.java 74.19% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad90eff...18c26c3. Read the comment docs.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks like it completely removes Whitelist api/settings that we have not publicly announced is to be deprecated.

How does this change relate to #1808?

@cliu123 cliu123 closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants