Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button label #2130

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Fix button label #2130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d80235b
Fix button label
derek-ho Oct 1, 2024
8a9990b
Debug
derek-ho Oct 1, 2024
0548091
look for server running instead of bundles compiled
derek-ho Oct 1, 2024
7d934e1
increase timeout to 900 seconds
derek-ho Oct 1, 2024
48c087f
Actually change timeout to 900 seconds
derek-ho Oct 1, 2024
514877c
Try compile step
derek-ho Oct 2, 2024
1e0e5ab
Bash
derek-ho Oct 2, 2024
8f83c1e
Fix messaging + look for start now that compile is different step
derek-ho Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/actions/run-cypress-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ runs:
fi
shell: bash

- name: Compile OpenSearch Dashboards
run: |
cd OpenSearch-Dashboards
node scripts/build_opensearch_dashboards_platform_plugins --no-examples --workers=10 --verbose
cwperks marked this conversation as resolved.
Show resolved Hide resolved
shell: bash

- name: Run OpenSearch Dashboards with provided configuration
if: ${{ runner.os == 'Linux' }}
run: |
Expand All @@ -80,13 +86,13 @@ runs:
run: |
cd ./OpenSearch-Dashboards
echo "Start checking OpenSearch Dashboards."
for i in {1..60}; do
if grep -q "bundles compiled successfully after" "dashboard.log"; then
echo "OpenSearch Dashboards compiled successfully."
for i in {1..6}; do
if grep -q "http server running" "dashboard.log"; then
echo "OpenSearch Dashboards started successfully."
break
fi
if [ $i -eq 60 ]; then
echo "Timeout for 600 seconds reached. OpenSearch Dashboards did not finish compiling."
if [ $i -eq 6 ]; then
echo "Timeout for 60 seconds reached. OpenSearch Dashboards did not start."
exit 1
fi
sleep 10
Expand Down
2 changes: 1 addition & 1 deletion public/apps/configuration/panels/get-started.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const addBackendStep = {
<ExternalLinkButton
fill
href={DocLinks.BackendConfigurationDoc}
text="Create config.yml"
text="Config.yml documentation"
/>
</EuiFlexItem>
<EuiFlexItem grow={false}>
Expand Down
2 changes: 1 addition & 1 deletion public/apps/configuration/panels/test/__snapshots__/get-started.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ exports[`Get started (landing page) renders when backend configuration is enable
<ExternalLinkButton
fill={true}
href="https://opensearch.org/docs/latest/security-plugin/configuration/configuration/"
text="Create config.yml"
text="Config.yml documentation"
/>
</EuiFlexItem>
<EuiFlexItem
Expand Down
Loading